github_app_access_token: add support for private key fact #8989
+106
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for specifying the GitHub App private key via an ansible fact instead of a path to a file. This is useful when you want to generate registration tokens for a remote host but don't want to put secrets on the host.
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
WIP
felixfontein
added
check-before-release
russoz
reviewed
Oct 10, 2024
There was a problem hiding this comment.
Hi @lewismiddleton thanks for your contribution!
I got only a couple of comments, the rest LGTM.
Comment on lines
94
to
95
| if private_key: | ||
| return jwk_from_pem(private_key.encode()) |
There was a problem hiding this comment.
If neither are passed by the user, they will get an error trying open the file None or something like that. I believe it would be better to have a validation check telling the user they must pass one or the other.
Co-authored-by: Alexei Znamensky <[email protected]> Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds support for specifying the GitHub App private key via an ansible fact instead of a path to a file.
This is useful when you want to generate registration tokens for a remote host but don't want to put secrets on the host.
ISSUE TYPE
COMPONENT NAME
github_app_access_tokenADDITIONAL INFORMATION