Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmware_local_user_manager - shell access #1790

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cbreuil-orange
Copy link

SUMMARY

vmware_local_user_manager

Add the possibility to grants or not the "shell access" for user creation or update

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vmware_local_user_manager

ADDITIONAL INFORMATION
https://vdc-repo.vmware.com/vmwb-repository/dcr-public/d1902b0e-d479-46bf-8ac9-cee0e31e8ec0/07ce8dbd-db48-4261-9b8f-c6d3ad8ba472/vim.host.LocalAccountManager.PosixAccountSpecification.html

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/28df9c727bf54679a45ad5888cede633

⚠️ ansible-tox-linters CANCELED
build-ansible-collection RETRY_LIMIT in 11m 10s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection

@mnaser
Copy link

mnaser commented Jul 12, 2023

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/2843b36651d34b41a4079e1a4f26744d

✔️ ansible-tox-linters SUCCESS in 8m 44s
✔️ build-ansible-collection SUCCESS in 9m 35s
ansible-test-cloud-integration-vcenter7_only-stable215 NODE_FAILURE Node request 200-0006196234 failed in 0s
ansible-test-cloud-integration-vcenter7_2esxi-stable215 NODE_FAILURE Node request 200-0006196235 failed in 0s
ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 NODE_FAILURE Node request 200-0006196236 failed in 0s
ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 NODE_FAILURE Node request 200-0006196237 failed in 0s
✔️ ansible-galaxy-importer SUCCESS in 3m 26s

@cbreuil-orange
Copy link
Author

recheck

@softwarefactory-project-zuul
Copy link

@ihumster
Copy link
Collaborator

recheck

@cbreuil-orange
Copy link
Author

recheck

@ihumster
Copy link
Collaborator

ihumster commented Sep 1, 2023

recheck

Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand the documentation correctly, I don't see how this can be implemented in a way that won't possibly break existing playbooks- at least not as long as there's a default for this parameter. I think it would be better to remove the defaul and ignore the parameter if it isn't set.

We could add a default in the next major release (4.0.0), but would prefer it to be false because it would be more secure by design. Giving accounts shell access (or any other privileges) should always be done explicitly imho ;-)

Additionally, please add a changelog fragment similar to this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants