Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding additional condition for rhel7stig_grub2_user_cfg for task #441

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Adding additional condition for rhel7stig_grub2_user_cfg for task #441

merged 1 commit into from
Oct 25, 2023

Conversation

layluke
Copy link
Contributor

@layluke layluke commented Oct 18, 2023

Overall Review of Changes:
Adds an additional condition to be satisfied in order for tasks to run for grub2 handlers

Issue Fixes:
#440

Enhancements:
N/A

How has this been tested?:
Tested against current version of RHEL7

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.

@uk-bolly
Copy link
Member

hi @layluke

Good catch in the PR, happy to merge but we do need to have the PR gpg signed. If you could add that to your commit happy to accept.
Thank you for taking the time to help improve ansible-lockdown.

many thanks

uk-bolly

@layluke
Copy link
Contributor Author

layluke commented Oct 21, 2023

hi @layluke

Good catch in the PR, happy to merge but we do need to have the PR gpg signed. If you could add that to your commit happy to accept. Thank you for taking the time to help improve ansible-lockdown.

many thanks

uk-bolly

Sorry about that, still getting the hang of git hub. I think it's good now. Let me know if there are any other issues.

Copy link
Member

@uk-bolly uk-bolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great change

@uk-bolly uk-bolly merged commit 5e47e97 into ansible-lockdown:devel Oct 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants