Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined variable in parse_etc_password.yml #146

Closed
adds68 opened this issue Nov 2, 2021 · 2 comments · Fixed by #151
Closed

Undefined variable in parse_etc_password.yml #146

adds68 opened this issue Nov 2, 2021 · 2 comments · Fixed by #151
Assignees
@uk-bolly
Labels
bug Something isn't working

Comments

@adds68
Copy link

adds68 commented Nov 2, 2021

Describe the Issue
Undefined variable in parse_etc_password.yml

5: - name: "PRELIM | {{ rhel8cis_passwd_tasks }} | Parse /etc/passwd"

Expected Behavior
I suspect it should be "5.5.2 | 6.2.7 | 6.2.8 6.2.20"

Actual Behavior
{{ rhel8cis_passwd_tasks }}

related to #61
@adds68 adds68 added the bug Something isn't working label Nov 2, 2021
@uk-bolly
Copy link
Member

Hi @adds68

Thank you for taking the time to raise this issue. Feedback can only help to improve the content that is delivered.
I can see this was previously resolved but missed one line in the control title.

I will be adding this fix to the next release.

Thank you once again

uk-bolly

@uk-bolly uk-bolly self-assigned this Dec 15, 2021
uk-bolly added a commit that referenced this issue Dec 15, 2021
@uk-bolly
#146 fixed title undefined variable
a2c6454 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly uk-bolly mentioned this issue Dec 15, 2021
Merged
uk-bolly added a commit that referenced this issue Dec 21, 2021
@uk-bolly
Merge pull request #151 from ansible-lockdown/audit_script
6818bbd 
Audit script
Overall Review of Changes:
Addition of audit script
Many issues resolved and added to the release

Issue Fixes:
#138
#139
#140
#141
#142
#143
#144
#146
#147

Enhancements:

Addition of audit updates
Now consistent metadata
Inline with other os agnostic variables for audit
if run manually or via ansible
removal of included goss module no longer required
@uk-bolly
Copy link
Member

uk-bolly commented Dec 27, 2021 •
edited
Loading

hi @adds68

Thank you again for the feedback.
An update the latest devel branch has now been released and this should address the issues you have seen here.
Please feel free to close the issue if all is working as expected or feedback accordingly.

Thanks again

uk-bolly

@uk-bolly uk-bolly linked a pull request Jan 5, 2022 that will close this issue
Audit script #151
Merged
@uk-bolly uk-bolly closed this as completed Jan 6, 2022
@georgenalen georgenalen mentioned this issue Apr 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uk-bolly uk-bolly

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Audit script ansible-lockdown/RHEL8-CIS
2 participants
@adds68 @uk-bolly