Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed empty lines #267

Merged
merged 3 commits into from
Mar 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ provider "aws" {

// Create a security group with access to port 22 and port 80 open to serve HTTP traffic


resource "random_id" "server" {
keepers = {
# Generate a new id each time we switch to a new AMI id
Expand Down Expand Up @@ -80,4 +79,3 @@ resource "local_file" "inventory" {
audit_git_version: devel
EOF
}

7 changes: 4 additions & 3 deletions .github/workflows/update_galaxy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ jobs:
update_role:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: hspaans/ansible-galaxy-action@master
- uses: actions/checkout@v3
- uses: robertdebock/galaxy-action@master
with:
api_key: ${{ secrets.GALAXY_API_KEY }}
galaxy_api_key: ${{ secrets.GALAXY_API_KEY }}
git_branch: main
2 changes: 2 additions & 0 deletions .yamllint
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ rules:
brackets:
max-spaces-inside: 1
level: error
empty-lines:
max: 1
line-length: disable
key-duplicates: enable
new-line-at-end-of-file: enable
Expand Down
1 change: 0 additions & 1 deletion CONTRIBUTING.rst
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ following text in your contribution commit message:

::


This message can be entered manually, or if you have configured git
with the correct `user.name` and `user.email`, you can use the `-s`
option to `git commit` to automatically include the signoff message.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,6 @@ uses:
- runs the audit using the devel branch
- This is an automated test that occurs on pull requests into devel


## Local Testing

Molecule can be used to work on this role and test in distinct _scenarios_.
Expand All @@ -179,6 +178,7 @@ molecule verify -s localhost
```

local testing uses:

- ansible 2.13.3
- molecule 4.0.1
- molecule-docker 2.0.0
Expand Down
1 change: 0 additions & 1 deletion ansible.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ stdout_callback = yaml
# Use the stdout_callback when running ad-hoc commands.
#bin_ansible_callbacks = True


[privilege_escalation]

[paramiko_connection]
Expand Down
5 changes: 0 additions & 5 deletions defaults/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,6 @@ rhel8cis_telnet_required: false
rhel8cis_openldap_clients_required: false
rhel8cis_tftp_client: false


rhel8cis_allow_autofs: false

## Section 1 vars
Expand All @@ -414,7 +413,6 @@ rhel8cis_rh_sub_password: password
# RedHat Satellite Subscription items
rhel8cis_rhnsd_required: false


# xinetd required
rhel8cis_xinetd_required: false

Expand Down Expand Up @@ -589,7 +587,6 @@ rhel8cis_ssh_loglevel: INFO
# 5.2.19 SSH MaxSessions setting. Must be 10 or less
rhel8cis_ssh_maxsessions: 10


# 5.3.1 Enable automation to create custom profile settings, using the settings above
rhel8cis_authselect_custom_profile_create: false

Expand Down Expand Up @@ -625,7 +622,6 @@ rhel8cis_pass:
min_days: 7
warn_age: 7


# 5.6.1.4
rhel8cis_inactivelock:
lock_days: 30
Expand Down Expand Up @@ -659,7 +655,6 @@ rhel8cis_rpm_audit_file: /var/tmp/rpm_file_check
rhel8cis_no_world_write_adjust: true
rhel8cis_passwd_label: "{{ (this_item | default(item)).id }}: {{ (this_item | default(item)).dir }}"


# 6.2.9 - adjusting symlinks in home directories
# Default in ansible is true this causes lots of issues for many users
# set as variable so can be overridden but default is not to follow.
Expand Down
3 changes: 0 additions & 3 deletions meta/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,8 @@ galaxy_info:
- redhat
- rhel
- compliance


collections:
- community.general
- community.crypto
- ansible.posix

dependencies: []
1 change: 0 additions & 1 deletion tasks/section_4/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
- name: "SECTION | 4.1.3.x| Configure auditd rules"
import_tasks: cis_4.1.3.x.yml


# 4.2 Configure Logging
- name: "SECTION | 4.2.1.x| Configure rsyslog"
import_tasks: cis_4.2.1.x.yml
Expand Down
1 change: 0 additions & 1 deletion tasks/section_6/cis_6.2.x.yml
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,6 @@
- users
- rule_6.2.9


- name: "6.2.10 | PATCH | Ensure users own their home directories"
file:
path: "{{ item.dir }}"
Expand Down
14 changes: 0 additions & 14 deletions templates/ansible_vars_goss.yml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,12 @@ rhel8cis_level_2: {{ rhel8cis_level_2 }}

rhel8cis_selinux_disable: {{ rhel8cis_selinux_disable }}



# to enable rules that may have IO impact on a system e.g. full filesystem scans or CPU heavy
run_heavy_tests: true
{% if rhel8cis_legacy_boot is defined %}
rhel8cis_legacy_boot: {{ rhel8cis_legacy_boot }}
{% endif %}


rhel8cis_set_boot_pass: {{ rhel8cis_set_boot_pass }}
# These variables correspond with the CIS rule IDs or paragraph numbers defined in
# the CIS benchmark documents.
Expand Down Expand Up @@ -110,11 +107,9 @@ rhel8cis_rule_1_8_3: {{ rhel8cis_rule_1_8_3 }}
rhel8cis_rule_1_8_4: {{ rhel8cis_rule_1_8_4 }}
rhel8cis_rule_1_8_5: {{ rhel8cis_rule_1_8_5 }}


rhel8cis_rule_1_9: {{ rhel8cis_rule_1_9 }}
rhel8cis_rule_1_10: {{ rhel8cis_rule_1_10 }}


# section 2 rules
rhel8cis_rule_2_1_1: {{ rhel8cis_rule_2_1_1 }}
rhel8cis_rule_2_1_2: {{ rhel8cis_rule_2_1_2 }}
Expand Down Expand Up @@ -206,7 +201,6 @@ rhel8cis_rule_3_4_3_3_4: {{ rhel8cis_rule_3_4_3_3_4 }}
rhel8cis_rule_3_4_3_3_5: {{ rhel8cis_rule_3_4_3_3_5 }}
rhel8cis_rule_3_4_3_3_6: {{ rhel8cis_rule_3_4_3_3_6 }}


# Section 4 rules
rhel8cis_rule_4_1_1_1: {{ rhel8cis_rule_4_1_1_1 }}
rhel8cis_rule_4_1_1_2: {{ rhel8cis_rule_4_1_1_2 }}
Expand Down Expand Up @@ -252,7 +246,6 @@ rhel8cis_rule_4_2_2_1_2: {{ rhel8cis_rule_4_2_2_1_2 }}
rhel8cis_rule_4_2_2_1_3: {{ rhel8cis_rule_4_2_2_1_3 }}
rhel8cis_rule_4_2_2_1_4: {{ rhel8cis_rule_4_2_2_1_4 }}


rhel8cis_rule_4_2_2_2: {{ rhel8cis_rule_4_2_2_2 }}
rhel8cis_rule_4_2_2_3: {{ rhel8cis_rule_4_2_2_3 }}
rhel8cis_rule_4_2_2_4: {{ rhel8cis_rule_4_2_2_4 }}
Expand All @@ -275,7 +268,6 @@ rhel8cis_rule_5_1_7: {{ rhel8cis_rule_5_1_7 }}
rhel8cis_rule_5_1_8: {{ rhel8cis_rule_5_1_8 }}
rhel8cis_rule_5_1_9: {{ rhel8cis_rule_5_1_9 }}


rhel8cis_rule_5_2_1: {{ rhel8cis_rule_5_2_1 }}
rhel8cis_rule_5_2_2: {{ rhel8cis_rule_5_2_2 }}
rhel8cis_rule_5_2_3: {{ rhel8cis_rule_5_2_3 }}
Expand Down Expand Up @@ -324,7 +316,6 @@ rhel8cis_rule_5_6_3: {{ rhel8cis_rule_5_6_3 }}
rhel8cis_rule_5_6_4: {{ rhel8cis_rule_5_6_4 }}
rhel8cis_rule_5_6_5: {{ rhel8cis_rule_5_6_5 }}


# Section 6
rhel8cis_rule_6_1_1: {{ rhel8cis_rule_6_1_1 }}
rhel8cis_rule_6_1_2: {{ rhel8cis_rule_6_1_2 }}
Expand Down Expand Up @@ -359,8 +350,6 @@ rhel8cis_rule_6_2_14: {{ rhel8cis_rule_6_2_14 }}
rhel8cis_rule_6_2_15: {{ rhel8cis_rule_6_2_15 }}
rhel8cis_rule_6_2_16: {{ rhel8cis_rule_6_2_16 }}



# Service configuration booleans set true to keep service
rhel8cis_avahi_server: {{ rhel8cis_avahi_server }}
rhel8cis_cups_server: {{ rhel8cis_cups_server }}
Expand All @@ -382,8 +371,6 @@ rhel8cis_telnet_server: {{ rhel8cis_telnet_server }}
rhel8cis_tftp_server: {{ rhel8cis_tftp_server }}
rhel8cis_vsftpd_server: {{ rhel8cis_vsftpd_server }}



rhel8cis_allow_autofs: {{ rhel8cis_allow_autofs }}

# client services
Expand Down Expand Up @@ -451,7 +438,6 @@ rhel8cis_firewall_interface:

rhel8cis_firewall_services: {% for svc in rhel8cis_firewall_services %}{{ svc }} {% endfor %}


### Section 4
## auditd settings
rhel8cis_auditd:
Expand Down