Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devel to main release #301

Merged
merged 65 commits into from
Jul 19, 2023
Merged

Devel to main release #301

merged 65 commits into from
Jul 19, 2023

Conversation

uk-bolly
Copy link
Member

@uk-bolly uk-bolly commented Jul 5, 2023

Overall Review of Changes:
Next release including many bug fixes and improvements

Issue Fixes:

thanks to @jonawang

thanks to @Crayeth

thanks to @Thulium-Drake

thanks to @bbaassssiiee

Enhancements:
Linting
container updates

How has this been tested?:
Manually
in devel for the last week with latest merge
pipeline

MrSteve81 and others added 30 commits April 10, 2023 11:49
Signed-off-by: Stephen Williams <[email protected]>
Readme Update, Module Names Update, Yamllint Update, Ansible-lint Check, YamllInt Check
Signed-off-by: Stephen Williams <[email protected]>
Module Change From Command To Shell, Update Names Of Tasks
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Bas Meijer <[email protected]>
Signed-off-by: Bas Meijer <[email protected]>
Added new options

Signed-off-by: Mark Bolwell <[email protected]>
updated control 5.3.7

Signed-off-by: Mark Bolwell <[email protected]>
faillock without authconfig option read changelog

Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
revert changes

Signed-off-by: Mark Bolwell <[email protected]>
new option to limit installed kernels

Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly uk-bolly requested a review from georgenalen July 5, 2023 16:03
@uk-bolly uk-bolly marked this pull request as ready for review July 5, 2023 16:03
Copy link
Member

@bbaassssiiee bbaassssiiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I run ansible-lint 6.4.0 with ansible 2.13.3 in the role's dir I noticed:

tasks/section_1/warning_facts.yml:1: load-failure (load-failure[filenotfounderror])
tasks/section_2/warning_facts.yml:1: load-failure (load-failure[filenotfounderror])
tasks/section_3/warning_facts.yml:1: load-failure (load-failure[filenotfounderror])
tasks/section_4/warning_facts.yml:1: load-failure (load-failure[filenotfounderror])
tasks/section_5/warning_facts.yml:1: load-failure (load-failure[filenotfounderror])
tasks/section_6/warning_facts.yml:1: load-failure (load-failure[filenotfounderror])

The warning_facts.yml is in the parent dir of the sections tasks files.

@uk-bolly
Copy link
Member Author

uk-bolly commented Jul 6, 2023

When I run ansible-lint 6.4.0 with ansible 2.13.3 in the role's dir I noticed:

tasks/section_1/warning_facts.yml:1: load-failure (load-failure[filenotfounderror])
tasks/section_2/warning_facts.yml:1: load-failure (load-failure[filenotfounderror])
tasks/section_3/warning_facts.yml:1: load-failure (load-failure[filenotfounderror])
tasks/section_4/warning_facts.yml:1: load-failure (load-failure[filenotfounderror])
tasks/section_5/warning_facts.yml:1: load-failure (load-failure[filenotfounderror])
tasks/section_6/warning_facts.yml:1: load-failure (load-failure[filenotfounderror])

The warning_facts.yml is in the parent dir of the sections tasks files.

Hi @bbaassssiiee

Thank for this, going through this today i'm not seeing the warning you are seeing. Im using a much newer version of ansible-lint
have tried both
ansible-lint 6.7.0
ansible-lint 6.17.2 (updated today and have a newer yamllint for a new branch i'm working on)

Many thanks

uk-bolly

Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Copy link
Contributor

@georgenalen georgenalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@uk-bolly uk-bolly merged commit 55efe9c into main Jul 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants