Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 3.1.3 and premediation/postmediation script calls #317

Merged
merged 4 commits into from
Sep 15, 2023

Conversation

cf-sewe
Copy link
Contributor

@cf-sewe cf-sewe commented Sep 15, 2023

Overall Review of Changes:

  • after recent change in run_audit.sh, the pre- and post mediation script would fail when multiple groups are specified.
  • the audit check 3.1.3 for dccp blacklist is expecting the change in blacklist.conf

Issue Fixes:
n/a

Enhancements:
n/a

How has this been tested?:
tested by running hardening playbook with premediation / postmediation audit scan.

@cf-sewe cf-sewe changed the title Fix/small fixes Fix for 3.1.3 and premediation/postmediation script calls Sep 15, 2023
Signed-off-by: Sebastian Weitzel <[email protected]>
Copy link
Member

@uk-bolly uk-bolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent catch on multiple groups

@uk-bolly uk-bolly merged commit dcd3997 into ansible-lockdown:devel Sep 15, 2023
3 checks passed
@uk-bolly
Copy link
Member

Thank you so much for your feedback and time, it is truly appreciated.

Great work

uk-bolly

@uk-bolly uk-bolly mentioned this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants