Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set user to root with podman #1539

Merged
merged 1 commit into from
May 20, 2023
Merged

Conversation

cidrblock
Copy link
Collaborator

Related: ansible/ansible-builder#541
Related: #1448

Due to changes with the container build introduced with builder version 3, we will now run as user=root in a podman container.

See the builder issue above for details

@github-actions github-actions bot added the bug Researched, reproducible, committed to fix label May 20, 2023
@cidrblock cidrblock requested a review from ssbarnea May 20, 2023 04:31
@ssbarnea ssbarnea changed the title Set user to root when podman Set user to root with podman May 20, 2023
@ssbarnea
Copy link
Member

@cidrblock I approved it but I need to mention that I do not see a test for it, and that is dangerous as it prevents us from introducing a regression in the future.

@cidrblock
Copy link
Collaborator Author

cidrblock commented May 20, 2023

@ssbarnea TY & sorry

I should have linked 2 issues related to that:

#1540
ansible/creator-ee#330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Researched, reproducible, committed to fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants