Use get_option api from callback plugins
#1142
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To load options, callback plugins can use `get_option` api. Allow this functionality for other callback plugin. Fixes: ansible#1077 Signed-off-by: Abhijeet Kasurde <[email protected]>
|
cc @sivel |
AlanCoding
reviewed
Oct 20, 2023
| @@ -348,6 +348,12 @@ def __init__(self): | |||
| self.play_uuids = set() | |||
| self.duplicate_play_counts = collections.defaultdict(lambda: 1) | |||
|
|
|||
| def set_options(self, task_keys=None, var_options=None, direct=None): | |||
There was a problem hiding this comment.
maybe it would be more robust to use *args, **kwargs to work with multiple versions. I see certain checks failed, but results expired.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
To load options, callback plugins can use
get_optionapi.Allow this functionality for other callback plugin.
Fixes: #1077
Signed-off-by: Abhijeet Kasurde [email protected]
ISSUE TYPE
COMPONENT NAME
ansible_runner/display_callback/callback/awx_display.py