Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in streaming code you hit if using more than 1 inventory #1166

Open
wants to merge 4 commits into
base: devel
Choose a base branch
from

Conversation

AlanCoding
Copy link
Member

Generally, ansible-runner will take a lot of different things from the inventory parameter.

  • A dict, which is the outright definition of an inventory
  • A list of strings that don't exist as files or folders, being an alternative definition of an inventory
  • A list of paths to inventory sources
  • A single string that is a path to an inventory source

If you look at what we're doing in several of this places, we obviously abandon support for all but the last of these formats. In containerized jobs, we don't support that either, less the inventory file is named "hosts" in the inventory folder... which may be the same as not providing the parameter in the first place.

This adds just enough support for those other cases to allow me to get it working with a list of inventory files.

@Akasurde Akasurde removed the needs_triage New item that needs to be triaged label Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants