Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decouple the testing requirements of ansys-mapdl-core #100

Open
jgd10 opened this issue Jan 21, 2022 · 2 comments
Open

decouple the testing requirements of ansys-mapdl-core #100

jgd10 opened this issue Jan 21, 2022 · 2 comments
Assignees

Comments

@jgd10
Copy link
Contributor

jgd10 commented Jan 21, 2022

The test suite relies on the installation of ansys-mapdl-core to operate properly. However, this also relies on an installation of this package, which results in a circular requirement and you end up installing the latest version of the package into your venv alongside the development version which is a recipe for confusion.

We should decouple these as suggested by Alex in #99

"by caching the expected results to *.npy arrays within testfiles."

@jgd10 jgd10 self-assigned this Jan 21, 2022
@jgd10
Copy link
Contributor Author

jgd10 commented Jan 21, 2022

At the moment tests won't run in PyCharm "Out of the box". And if you run pytest itself within the tests folder, it uses the installed version and not the development version.

@jgd10
Copy link
Contributor Author

jgd10 commented Jan 31, 2022

So, the solution to this was to install in development mode and use Python 3.8 (3.9 didn't work). I have summarised the steps I took and added them to the README on the project. This was merged in in PR #103. The tests are still coupled, but the original problem is gone. This ticket should remain open, but is of lower priority now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant