feat: Add overwrite option for App.save_as()
#951
Conversation
github-actions
bot
added
the
documentation
| Whether the file should be overwritten if it already exists (default is False). | ||
| """ | ||
| if not os.path.exists(path): | ||
| self.DataModel.Project.SaveAs(path) |
There was a problem hiding this comment.
return after this so we don't need to have any indent below
|
|
||
| try: | ||
| # Move existing file to temp location | ||
| shutil.move(path, temp_file_path) |
There was a problem hiding this comment.
@dipinknair why don't we just delete the files in path and save_as to it?
There was a problem hiding this comment.
In case if it fails to do a save_as, we should not be losing the existing saved files right ?
There was a problem hiding this comment.
I'm fine with it. The user said to overwrite, I suppose they must not care too much about losing the files they ask to overwrite
| # Move existing file to temp location | ||
| shutil.move(path, temp_file_path) | ||
| # Save as new file | ||
| self.DataModel.Project.SaveAs(path) |
There was a problem hiding this comment.
remember that the outcome of a save is both a mechdb and an accompanying folder. We need to overwrite the accompanying folder too
There was a problem hiding this comment.
I see. I will update accordingly.
Incase fails retrieve file from temp location
Closes #900