Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve Empty component again #15487

Merged
merged 17 commits into from
Mar 20, 2019
Merged

feat: Improve Empty component again #15487

merged 17 commits into from
Mar 20, 2019

Conversation

DiamondYuan
Copy link
Contributor

@DiamondYuan DiamondYuan commented Mar 18, 2019

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

👻 What's the background?

  1. Describe the source of requirement, like related issue link.

  2. Describe the problem and the scenario.

💡 Solution

  1. How to fix the problem, and list final API implementation and usage sample if that is an new feature.

  2. GIF or snapshot should be provided if includes UI/interactive modification.

📝 Changelog description

Describe changes from userside, and list all potential break changes or other risks.

  1. English description

  2. Chinese description (optional)

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@DiamondYuan DiamondYuan mentioned this pull request Mar 18, 2019
13 tasks
@DiamondYuan DiamondYuan changed the title feat: Improve Empty component again [wip] feat: Improve Empty component again Mar 18, 2019
@DiamondYuan
Copy link
Contributor Author

DiamondYuan commented Mar 18, 2019

@zombieJ 先 review 实现吧,可以的话我再把 测试/demo 改了。

@netlify
Copy link

netlify bot commented Mar 18, 2019

Deploy preview for ant-design ready!

Built with commit 780e51b

https://deploy-preview-15487--ant-design.netlify.com

components/empty/index.tsx Outdated Show resolved Hide resolved
@DiamondYuan
Copy link
Contributor Author

ImageType 这个名字是否需要改成 EmptyImage

@DiamondYuan DiamondYuan changed the title [wip] feat: Improve Empty component again feat: Improve Empty component again Mar 18, 2019
@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #15487 into feature will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #15487      +/-   ##
===========================================
- Coverage    94.14%    94.1%   -0.04%     
===========================================
  Files          250      250              
  Lines         6643     6637       -6     
  Branches      1931     1940       +9     
===========================================
- Hits          6254     6246       -8     
- Misses         388      390       +2     
  Partials         1        1
Impacted Files Coverage Δ
components/config-provider/renderEmpty.tsx 86.66% <100%> (ø) ⬆️
components/empty/index.tsx 94.73% <100%> (-1.27%) ⬇️
components/upload/UploadList.tsx 94.49% <0%> (-1.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eacf35d...780e51b. Read the comment docs.

@DiamondYuan
Copy link
Contributor Author

DiamondYuan commented Mar 19, 2019

用 base64 ?

@afc163

现在还是 feature 分支,图片地址改了。不方便用 GitHub 的图片

或者干脆删了这一段?反正下面的 demo 里面已经写了

@afc163
Copy link
Member

afc163 commented Mar 19, 2019

image

image

文档里直接贴链接展示就行。

![image](https://user-images.githubusercontent.com/507615/54591670-ac0a0180-4a65-11e9-846c-e55ffce0fe7b.png)

![image](https://user-images.githubusercontent.com/507615/54591679-b0ceb580-4a65-11e9-925c-ad15b4eae93d.png)

components/empty/index.tsx Outdated Show resolved Hide resolved
@DiamondYuan DiamondYuan requested a review from afc163 March 20, 2019 06:58
@afc163 afc163 merged commit addc7bd into feature Mar 20, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat-improveEmpty branch March 20, 2019 09:45
@afc163
Copy link
Member

afc163 commented Mar 21, 2019

#15442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants