fix: unified modal and drawer protal and fix overflow conflict #17600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![tests-checker[bot]](https://avatars.githubusercontent.com/in/17064?s=60&v=4){kind=small}
|
Deploy preview for ant-design ready! Built with commit d0c636f |
|
为什么 15 会挂? |
|
别搞15了 又没啥人用 都快17了 |
Codecov Report
@@ Coverage Diff @@
## master #17600 +/- ##
==========================================
- Coverage 96.09% 96.05% -0.05%
==========================================
Files 267 267
Lines 7433 7425 -8
Branches 2035 2033 -2
==========================================
- Hits 7143 7132 -11
- Misses 288 291 +3
Partials 2 2
Continue to review full report at Codecov.
|
|
我也觉得，，汗。。。 |
|
干他娘的，，怎么又挂了。。。 |
|
3.x 版本里 15 还是要看的。 |
|
16那么多好用的都不能用 |
1 task
zombieJ
reviewed
Jul 16, 2019
| | getContainer | 指定 Drawer 挂载的 HTML 节点 | HTMLElement \| `() => HTMLElement` \| Selectors | 'body' | 3.7.0 | | ||
| | maskClosable | 点击蒙层是否允许关闭 | boolean | true | 3.7.0 | 3.7.0 | | ||
| | mask | 是否展示遮罩 | Boolean | true | | ||
| | getContainer | 指定 Drawer 挂载的 HTML 节点, false 为挂载在当前 dom | HTMLElement \| `() => HTMLElement` \| Selectors \| false | 'body' | 3.7.0 | |
There was a problem hiding this comment.
不算吧。这 API 本来就存在的，drawer 本来就支持的，，现在是全部都放出来了，，modal 的是跟 drawer 统一了。。不算新功能吧。。
|
@afc163 review |
afc163
changed the title
afc163
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
👻 What's the background?
💡 Solution
📝 Changelog
2. 更新 drawer 和 modal 的 getContainer, 同时支持 HTMLElement |
() => HTMLElement| Selectors | false, false 为渲染在当前 dom 里☑️ Self Check before Merge
View rendered components/drawer/index.en-US.md
View rendered components/drawer/index.zh-CN.md
View rendered components/modal/index.en-US.md
View rendered components/modal/index.zh-CN.md