fix(layoutSider): dimensionMap for max-width media query #18553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to visibility problem (on viewport breakpoints) with Sider menu in our App And according to Bootstrap responsive breakpoints https://getbootstrap.com/docs/4.0/layout/overview/#responsive-breakpoints We should use different values for `min-width` and `max-width`. For example, if we construct query with `min-width: 768px` then we MUST use `max-width: 767.98px` for proper breakpoint determination otherwise they conflict with each other when have similar values.
|
Deploy preview for ant-design ready! Built with commit ff83e1a |
Codecov Report
@@ Coverage Diff @@
## master #18553 +/- ##
=======================================
Coverage 96.73% 96.73%
=======================================
Files 280 280
Lines 7532 7532
Branches 2053 2084 +31
=======================================
Hits 7286 7286
Misses 244 244
Partials 2 2
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #18553 +/- ##
=======================================
Coverage 96.73% 96.73%
=======================================
Files 280 280
Lines 7532 7532
Branches 2053 2084 +31
=======================================
Hits 7286 7286
Misses 244 244
Partials 2 2
Continue to review full report at Codecov.
|
|
Could you fill the changelog part for information? |
|
@afc163 done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to visibility problem (on viewport breakpoints) with Sider menu in our App
And according to Bootstrap responsive breakpoints https://getbootstrap.com/docs/4.0/layout/overview/#responsive-breakpoints
We should use different values for
min-widthandmax-width. For example, if we construct query withmin-width: 768pxthen we MUST usemax-width: 767.98pxfor proper breakpoint determination otherwise they conflict with each other when have similar values.🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge