style(Modal): Adopt a better way to break lines #39249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
MuxinFeng
force-pushed
the
fix-table-cell
branch
from
6a167cc
to
d2d4e50
Compare
afc163
requested changes
Dec 4, 2022
| @@ -297,7 +297,7 @@ const genModalConfirmStyle: GenerateStyle<ModalToken> = (token) => { | |||
|
|
|||
| [`+ ${confirmComponentCls}-content`]: { | |||
| marginBlockStart: token.marginXS, | |||
| flexBasis: "100%", | |||
| flexBasis: '100%', | |||
There was a problem hiding this comment.
Suggested change
| flexBasis: '100%', | |
| flexBasis: '100%', | |
| maxWidth: `calc(100% - ${token.modalConfirmIconSize + token.marginSM}px)`, |
改这个就好。别动 wordWrap，和 4.x 保持一致就行。
There was a problem hiding this comment.
代码改好了，changelog也改好了。
对于word-break这个方案不能用的情况我还有些疑惑，并且在历史 pr 里没找到相关的说明，大佬能给些关键词吗
There was a problem hiding this comment.
break-word 会让英文单词被砍断，不是最合理的排版方式，所以一般不会作为默认样式设置。
afc163
reviewed
Dec 4, 2022
components/modal/demo/hooks.tsx
Outdated
| <UnreachableContext.Consumer>{(name) => `Unreachable: ${name}!`}</UnreachableContext.Consumer> | ||
| </> | ||
| ), | ||
| content: <p>`Reachable: !aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)`</p>, |
MuxinFeng
force-pushed
the
fix-table-cell
branch
from
d2d4e50
to
34280f6
Compare
codeball-ai-writer
bot
added
codeball:needs-careful-review
and removed
codeball:needs-review
labels
afc163
approved these changes
Dec 4, 2022
This was referenced Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
使用 Modal.info(), content 属性中的内容较长时，会超出 Modal 边界
💡 Background and solution
📝 Changelog
max-widthtomodal-confirm-contentto achieve a line break effect (a supplement tonon-CJKtext wrapping)modal-confirm-content加上max-width，来达到换行效果（算是对非CJK文字换行的补充）☑️ Self-Check before Merge