Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade react-slick #48093

Merged
merged 4 commits into from
Mar 27, 2024
Merged

feat: upgrade react-slick #48093

merged 4 commits into from
Mar 27, 2024

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Mar 26, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

更新上游:ant-design/react-slick#110

📝 Changelog

Language Changelog
🇺🇸 English Fix Carousel several bugs by upgrading react-slick changes and renewing TS type.
🇨🇳 Chinese Carousel 组件同步上游 react-slick 改动,修复一系列问题,并更新到最新 TS 定义。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Mar 26, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Mar 26, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Mar 26, 2024

👁 Visual Regression Report for PR #48093 Passed ✅

🎯 Target branch: feature (e5849fc)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

github-actions bot commented Mar 26, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 335.21 KB (+90 B 🔺)
./dist/antd-with-locales.min.js 382.12 KB (+238 B 🔺)

package.json Outdated Show resolved Hide resolved
Copy link

codesandbox-ci bot commented Mar 26, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@afc163 afc163 changed the base branch from master to feature March 26, 2024 10:08
@afc163 afc163 marked this pull request as ready for review March 26, 2024 10:10
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f0ba86a) to head (fce01db).
Report is 1 commits behind head on feature.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #48093   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          739       739           
  Lines        12699     12699           
  Branches      3339      3339           
=========================================
  Hits         12699     12699           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan
Copy link
Member

size-limit 大了 200 多是预期的吗?

@li-jia-nan li-jia-nan mentioned this pull request Mar 26, 2024
20 tasks
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/@ant-design/[email protected], npm/@ant-design/[email protected], npm/@ant-design/[email protected], npm/@ant-design/[email protected], npm/@ant-design/[email protected], npm/@ant-design/[email protected], npm/@ant-design/[email protected], npm/@antv/[email protected], npm/@babel/[email protected], npm/@biomejs/[email protected], npm/@ctrl/[email protected], npm/@dnd-kit/[email protected], npm/@dnd-kit/[email protected], npm/@dnd-kit/[email protected], npm/@dnd-kit/[email protected], npm/@emotion/[email protected], npm/@emotion/[email protected], npm/@ianvs/[email protected], npm/@madccc/[email protected], npm/@qixian.cs/[email protected], npm/@rc-component/[email protected], npm/@rc-component/[email protected], npm/@rc-component/[email protected], npm/@rc-component/[email protected], npm/@size-limit/[email protected], npm/@stackblitz/[email protected], npm/@testing-library/[email protected], npm/@testing-library/[email protected], npm/@testing-library/[email protected], npm/@testing-library/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@afc163 afc163 merged commit 3518631 into feature Mar 27, 2024
108 checks passed
@afc163 afc163 deleted the feat/upgrade-react-slick branch March 27, 2024 05:34
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

MadCcc added a commit that referenced this pull request Mar 31, 2024
* fix: consistent with the tag component, the processing state uses colorInfo token. (#47695)

Signed-off-by: pfdgithub <[email protected]>

* feat: Notification support aria-* in closable (#47710)

* feat: Notification support aria-* in closable

* feat: optimize code

* Cascader support option render (#47727)

* feat: done

* feat: doc

* feat: improve Transfer `key` type (#47879)

* feat: add Transfer's key type

* docs: update prop

* fix: key type

* fix: cycle dependency

* chore: update size limit (#47903)

Signed-off-by: Amumu <[email protected]>

* chore: update size limit (#47904)

* feat: add Uzbek(latn) locale (#47899)

* feat: add Uzbek(latn) locale

* size-limit

* Update docs/react/i18n.zh-CN.md

Co-authored-by: afc163 <[email protected]>
Signed-off-by: Amumu <[email protected]>

---------

Signed-off-by: Amumu <[email protected]>
Co-authored-by: afc163 <[email protected]>
Co-authored-by: lijianan <[email protected]>

* feat: support `showSorterTooltip.target` for Table sorters (#47409)

* Added `sorterTooltipTarget` prop for table sorters

* demo updated

* updated snapshot

* updated snapshot

* moved table tooltip target to `showSorterTooltip`

* fix

* updated docs

* empty commit

* updated version in docs

---------

Co-authored-by: Alina Andrieieva <[email protected]>

* feat: CP support FloatButton.Group closeIcon (#47953)

* Typography support collapse (#47264)

* feat: typograohy support collapse

* feat: snap

* feat: test

* feat: 单测不符合预期

* feat: test

* feat: 恢复

* feat: test

* feat: test

* feat: 修改命名

* feat: 代码优化

* feat: 添加控制台提示

* feat: snap

* feat: symbol support function

* feat: snap

* fix: text

* feat: snap

* feat: api 修改

* feat: key 修改

* feat: 去掉参数

* feat: lint

* feat: snap

* feat: test

* feat: use 2

* feat: review

* feat: test

* chore: part of it

* chore: fix auto collapse logic

* feat: 修改 doc 单测

* feat: doc

* test: update testcase

* docs: add more

---------

Co-authored-by: 二货机器人 <[email protected]>

* feat: Table support onScroll event (#47986)

* feat: Popover can be closed by ESC when trigger is focus or click (#47928)

* feat:Add keydown event to handle escape

* fix

* fix:use exact same logic with popconfirm

* fix:move same logic from popconfirm to popover

* fix

* fix

* add test

* fix

* fix

* fix

* test size-limit

* fix

* fix popconfirm test

* fix

* fix

---------

Co-authored-by: afc163 <[email protected]>

* chore: update size-limit (#48014)

* feat: steps support for circular progress bar (#47940)

* feat: steps support for circular progress bar

* Update components/progress/index.zh-CN.md

Co-authored-by: afc163 <[email protected]>
Signed-off-by: lijianan <[email protected]>

* Update components/progress/index.en-US.md

Signed-off-by: lijianan <[email protected]>

* Update components/progress/index.en-US.md

Signed-off-by: lijianan <[email protected]>

* Update components/progress/index.zh-CN.md

Signed-off-by: lijianan <[email protected]>

* Update components/progress/index.zh-CN.md

Signed-off-by: lijianan <[email protected]>

* Update components/progress/index.en-US.md

Signed-off-by: lijianan <[email protected]>

* Update components/progress/progress.tsx

Signed-off-by: lijianan <[email protected]>

* Update components/progress/__tests__/index.test.tsx

Signed-off-by: lijianan <[email protected]>

* Update components/progress/demo/circle-steps.tsx

Signed-off-by: lijianan <[email protected]>

* Update components/progress/index.en-US.md

Signed-off-by: lijianan <[email protected]>

* Update components/progress/index.en-US.md

Signed-off-by: lijianan <[email protected]>

* Update components/progress/index.zh-CN.md

Signed-off-by: lijianan <[email protected]>

* Update components/progress/index.zh-CN.md

Signed-off-by: lijianan <[email protected]>

* Update circle-steps.tsx

* Update components/progress/progress.tsx

Signed-off-by: lijianan <[email protected]>

* Update components/progress/index.zh-CN.md

Signed-off-by: lijianan <[email protected]>

* Update components/progress/index.zh-CN.md

Signed-off-by: lijianan <[email protected]>

* Update components/progress/index.en-US.md

Signed-off-by: lijianan <[email protected]>

* Update components/progress/index.en-US.md

Signed-off-by: lijianan <[email protected]>

* Update package.json

* Update components/progress/demo/circle-steps.md

Co-authored-by: afc163 <[email protected]>
Signed-off-by: lijianan <[email protected]>

---------

Signed-off-by: lijianan <[email protected]>
Co-authored-by: lijianan <[email protected]>
Co-authored-by: afc163 <[email protected]>

* demo: update Progress demo (#48052)

* demo: update Progress demo

* fix: fix

* fix: fix

* fix: fix

* fix: update snap

* chore: update size-limit (#48098)

* feat: add Scrollbar css token (#48109)

* feat: add Scrollbar css token

* docs: update docs

* feat: upgrade react-slick (#48093)

* feat: upgrade react-slick

* test: update snapshots

* test: update snapshots

---------

Co-authored-by: lijianan <[email protected]>

* Revert "feat: add Scrollbar css token (#48109)" (#48115)

This reverts commit d0cc93b.

* feat: Input.OTP component support (#48076)

* chore: basic control

* chore: input instad

* docs: update demo

* chore: adjust operation interactive

* chore: lock selection

* chore: fix patch logic

* chore: merge logic

* chore: patch autoFocus

* test: update snapshot

* test: add test case

* test: coverage

* chore: update size limit

* docs: update docs

* test: fix test case

* chore: update comment

* refactor: change to length

* chore: blur all

* chore: size limit

* fix: Upload remove margin using flex display (#48091)

* fix: remove upload margin with flex

* fix

* use support not

* fix

* feat: copy support async (#48123)

* feat: copy support async

* feat: add test

* feat: doc

* feat: snap

* feat: add loading

* feat: 恢复 try

* feat: 判断是否是 Error

* feat: throw error

* feat: 为了醋包了饺子

* feat: remove code

* feat: add loading test

* fix: test

* fix: icon import way

* chore: improve test case code

* chore: improve test case code

---------

Co-authored-by: afc163 <[email protected]>

* feat: Table add `rowHoverable` to disable hover interaction (#48112)

* feat: Tag support aria-* in closable (#47678)

* feat: Tag support aria-* in closable

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* refactor: useClosable

* chore: modal

* fix: check logic

* chore: clean up

* feat: optimize code

* feat: optimize code

---------

Signed-off-by: kiner-tang <[email protected]>
Co-authored-by: 二货机器人 <[email protected]>

---------

Signed-off-by: pfdgithub <[email protected]>
Signed-off-by: Amumu <[email protected]>
Signed-off-by: lijianan <[email protected]>
Signed-off-by: kiner-tang <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: pfdgithub <[email protected]>
Co-authored-by: kiner-tang <[email protected]>
Co-authored-by: 叶枫 <[email protected]>
Co-authored-by: lijianan <[email protected]>
Co-authored-by: 章鱼怪 <[email protected]>
Co-authored-by: Amumu <[email protected]>
Co-authored-by: afc163 <[email protected]>
Co-authored-by: Alina Andrieieva <[email protected]>
Co-authored-by: Alina Andrieieva <[email protected]>
Co-authored-by: 二货机器人 <[email protected]>
Co-authored-by: Cooper <[email protected]>
Co-authored-by: yykoypj <[email protected]>
@MadCcc MadCcc mentioned this pull request Mar 31, 2024
CooperHash pushed a commit to CooperHash/ant-design that referenced this pull request Apr 10, 2024
* feat: upgrade react-slick

* test: update snapshots

* test: update snapshots

---------

Co-authored-by: lijianan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants