Add some methods for Go runtime #4626
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Buhr <[email protected]> Signed-off-by: Robert Einhorn <[email protected]>
Added methods for CommonToken class: SetChannel SetStop SetText // also exists in Token (Token.SetText may be unnecessary) SetTokenType Modified CommonToken class method: Clone Added methods for Lexer class: GetModeStack GetMode Signed-off-by: Robert Einhorn <[email protected]>
jimidle
reviewed
May 23, 2024
related issue: #4625 Signed-off-by: Robert Einhorn <[email protected]>
Signed-off-by: Robert Einhorn <[email protected]>
Signed-off-by: Robert Einhorn <[email protected]>
|
Can I expect a review on this? |
|
Here is a Python parser with a Go port that already uses the above modifications. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added methods for CommonToken class:
SetChannel
SetStop
SetText // also exists in Token (Token.SetText may be unnecessary)
SetTokenType
Added constructor for CommonToken class:
CommonToken.NewCommonTokenFromToken
Removed method in CommonToken class:
Clone
Added methods for Lexer class:
GetModeStack
GetMode
The equivalent of the NewCommonTokenFromToken constructor can also be found in the Java CommonToken class.
The NewCommonTokenFromToken constructor is similar to the clone method, in that a cloned CommonToken instance is created in both.
NewCommonTokenFromToken accepts both Token and CommonToken parameters for cloning.
This made the clone method redundant.