Release 3.2.2 - Session renaming bug (#164)

antoinejaussoin · Nov 8, 2020 · 9ddd9a5 · 9ddd9a5
1 parent 5aa53bd
commit 9ddd9a5
Show file tree

Hide file tree

Showing 9 changed files with 25 additions and 12 deletions.
diff --git a/README.md b/README.md
@@ -143,6 +143,10 @@ When using the Docker deployment, your database runs from a container. But if yo
 
 ## Versions History
 
+### Version 3.2.2
+
+- Fixed a bug where any user editing the name of the session would become owner of the session.
+
 ### Version 3.2.1
 
 - Fixed a serious bug under Firefox, where users could not see the content of the post ([#154](https:/antoinejaussoin/retro-board/issues/154), [#148](https:/antoinejaussoin/retro-board/issues/148)). 👏 Thanks to all people who reported this ([@Xyaren](https:/Xyaren), [@dallasgutauckis](https:/dallasgutauckis), [@courtney-thwaites](https:/courtney-thwaites)).

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
  "name": "retro-board",
- "version": "3.2.1",
+ "version": "3.2.2",
  "description": "An agile retrospective board - Powering www.retrospected.com",
  "private": true,
  "workspaces": [

diff --git a/retro-board-app/package.json b/retro-board-app/package.json
@@ -1,6 +1,6 @@
 {
  "name": "retro-board-app",
- "version": "3.2.1",
+ "version": "3.2.2",
  "license": "GNU GPLv3",
  "private": true,
  "dependencies": {

diff --git a/retro-board-common/package.json b/retro-board-common/package.json
@@ -1,6 +1,6 @@
 {
  "name": "retro-board-common",
- "version": "3.2.1",
+ "version": "3.2.2",
  "license": "GNU GPLv3",
  "private": true,
  "main": "dist/src/index.js",

diff --git a/retro-board-server/package.json b/retro-board-server/package.json
@@ -1,6 +1,6 @@
 {
  "name": "retro-board-server",
- "version": "3.2.1",
+ "version": "3.2.2",
  "license": "GNU GPLv3",
  "private": true,
  "scripts": {

diff --git a/retro-board-server/src/db/postgres.ts b/retro-board-server/src/db/postgres.ts
@@ -273,6 +273,13 @@ const getOrSaveUser = (userRepository: UserRepository) => async (
  return await userRepository.saveFromJson(user);
 };
 
+const updateName = (sessionRepository: SessionRepository) => async (
+ sessionId: string,
+ name: string
+): Promise<void> => {
+ await sessionRepository.updateName(sessionId, name);
+};
+
 const deleteSessions = (sessionRepository: SessionRepository) => async (
  userId: string,
  sessionId: string
@@ -418,5 +425,6 @@ export default async function db(): Promise<Store> {
  previousSessions: previousSessions(sessionRepository),
  getDefaultTemplate: getDefaultTemplate(userRepository),
  deleteSession: deleteSessions(sessionRepository),
+ updateName: updateName(sessionRepository),
  };
 }
diff --git a/retro-board-server/src/db/repositories/SessionRepository.ts b/retro-board-server/src/db/repositories/SessionRepository.ts
@@ -16,6 +16,13 @@ export default class SessionRepository extends Repository<Session> {
  });
  return options;
  }
+ async updateName(sessionId: string, name: string) {
+ const sessionEntity = await this.findOne(sessionId);
+ if (sessionEntity) {
+ sessionEntity.name = name;
+ await this.save(sessionEntity);
+ }
+ }
  async saveFromJson(
  session: Omit<JsonSession, 'createdBy'>,
  authorId: string

diff --git a/retro-board-server/src/game.ts b/retro-board-server/src/game.ts
@@ -96,13 +96,6 @@ export default (store: Store, io: SocketIO.Server) => {
  socket.emit(action, data);
  };
 
- const persistSession = async (userId: string | null, session: Session) => {
- if (!userId) {
- return;
- }
- await store.saveSession(userId, session);
- };
-
  const updateOptions = async (
  userId: string | null,
  session: Session,
@@ -276,7 +269,7 @@ export default (store: Store, io: SocketIO.Server) => {
  return;
  }
  session.name = data.name;
- await persistSession(userId, session);
+ await store.updateName(session.id, data.name);
  sendToAll(socket, session.id, RECEIVE_SESSION_NAME, data.name);
  };
 

diff --git a/retro-board-server/src/types.ts b/retro-board-server/src/types.ts
@@ -60,6 +60,7 @@ export interface Store {
  session: Session,
  columns: ColumnDefinition[]
  ) => Promise<ColumnDefinition[]>;
+ updateName: (sessionId: string, name: string) => Promise<void>;
 }
 
 export interface Configuration {