-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breeze build image or docs behind proxy #17158
Comments
Thanks for opening your first issue here! Be sure to follow the issue template! |
Thanks! Very interesting and useful I think. I think the way you described id is exactly how it should be done. Would you like to contribute a PR with those changes? In order to make it more "complete" the parameters should follow the convention AIRFLOW_HTTP_PROXY, AIRFLOW_HTTPS_PROXY and update the documentation in IMAGES.rst and maybe a few other places where build-args are mentioned (also in the instructions in `docs/docker-stack'. I'd love if you contribute that change @ciancolo ? Would you :D ? |
I will try to propose a PR. |
Most of the scripts in dev env are used in CI to run tests so pretty much all of them are tested in every single PR, same with Docker - it is build in a number of combinations and even automatically tested during the CI builds, so whenever you PR gets "green" you should not worry about regressions. About 90% of the dev scripts are also used for CI I'd estimate. And those that are not tested are mostly the ones that are very much "user-facing" When it come to testing with proxy, we have no environment prepared to test it with a proxy, unless you want to set it up in our CI, but I think it's a bit too much hassle and it's a bit too "niche" to setup a CI for it, So I'd say review + manual testing should suffice. |
Hey @ciancolo - how about the change here :) ? |
Hi @potiuk, Currently, I'm in vacation with no access to my dev env. I'm going to complete the work when I will back to work. |
Hello all,
Description
Add to Breeze commands
build-image
andbuild-docs
(needs also in other commands?) a parameter (or more) to specify proxy configurations for the image and docs build.Use case / motivation
Recently I started to contribute to Airflow project, but I had some problems creating and configure the development environment with Breeze. My workstation is behind my company proxy and this creates a problem in the download of the necessary Python packages and the GPG public key during the image build. My workstation is already configured to work with proxy (I configured apt, docker...) but in this case, it didn't work.
I have a similar problem with
./breeze build-docs
command.Are you willing to submit a PR?
I'm not an expert in Breeze or bash script. Applying these 2 changes was enough to be able to build the image with Breeze:
scripts/ci/libraries/_build_images.sh
scripts/docker/install_mysql.sh
But of course, it will be better to use some global parameters, and I don't know if there are other cases where it is important to set proxy configuration.
The text was updated successfully, but these errors were encountered: