Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accept_none to SQLTableCheckOperator #30082

Open
1 of 2 tasks
mag3141592 opened this issue Mar 13, 2023 · 1 comment
Open
1 of 2 tasks

Add accept_none to SQLTableCheckOperator #30082

mag3141592 opened this issue Mar 13, 2023 · 1 comment

Comments

@mag3141592
Copy link

Description

Right now, SQLColumnCheckOperator has an accept_none parameter that allows a test to pass if the table is empty. For parity, I think this functionality should be available on the SQLTableCheckOperator.

Use case/motivation

I have a table, that may or may not have data in it on a give day.

If it has data in it, I would like it to pass the test I set but if it doesn't I don't want it to fail by default.

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@mag3141592 mag3141592 added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels Mar 13, 2023
@josh-fell josh-fell added provider:common-sql good first issue and removed needs-triage label for new issues that we didn't triage yet labels Mar 14, 2023
@denimalpaca
Copy link
Contributor

@josh-fell this can be assigned to me

@mag3141592 if accept_none is True, we still need a default behavior for how the operator handles the tests in its check dict. I don't think marking all the tests True is correct behavior, but False is also probably not correct behavior, as the tests are simply not running. Should the operator simply return here?

I can see a case where the OpenLineage extractor breaks if no boolean value is given to the success field of the check dict, so I do think some default behavior there is warranted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants