Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Click 8.1.4 breaks mypy typing checks #32412

Closed
1 task done
potiuk opened this issue Jul 6, 2023 · 2 comments · Fixed by #32634
Closed
1 task done

Click 8.1.4 breaks mypy typing checks #32412

potiuk opened this issue Jul 6, 2023 · 2 comments · Fixed by #32634
Labels
kind:meta High-level information important to the community

Comments

@potiuk
Copy link
Member

potiuk commented Jul 6, 2023

Body

The Click 8.1.4 released 06.06.2023 broke a number of mypy checks. Until the problem is fixed, we need to limit click to unbreak main.

Example failing job: https:/apache/airflow/actions/runs/5480089808/jobs/9983219862

Example failures:

dev/breeze/src/airflow_breeze/utils/common_options.py:78: error: Need type
annotation for "option_verbose"  [var-annotated]
    option_verbose = click.option(
                     ^
dev/breeze/src/airflow_breeze/utils/common_options.py:89: error: Need type
annotation for "option_dry_run"  [var-annotated]
    option_dry_run = click.option(
                     ^
dev/breeze/src/airflow_breeze/utils/common_options.py:100: error: Need type
annotation for "option_answer"  [var-annotated]
    option_answer = click.option(
                    ^
dev/breeze/src/airflow_breeze/utils/common_options.py:109: error: Need type
annotation for "option_github_repository"  [var-annotated]
    option_github_repository = click.option(
                               ^
dev/breeze/src/airflow_breeze/utils/common_options.py:118: error: Need type
annotation for "option_python"  [var-annotated]
    option_python = click.option(
                    ^
dev/breeze/src/airflow_breeze/utils/common_options.py:127: error: Need type
annotation for "option_backend"  [var-annotated]
    option_backend = click.option(
                     ^
dev/breeze/src/airflow_breeze/utils/common_options.py:136: error: Need type
annotation for "option_integration"  [var-annotated]
    option_integration = click.option(
                         ^
dev/breeze/src/airflow_breeze/utils/common_options.py:142: error: Need type
annotation for "option_postgres_version"  [var-annotated]
    option_postgres_version = click.option(
                              ^
dev/breeze/src/airflow_breeze/utils/common_options.py:150: error: Need type
annotation for "option_mysql_version"  [var-annotated]
    option_mysql_version = click.option(
                           ^

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@potiuk potiuk added the kind:meta High-level information important to the community label Jul 6, 2023
@potiuk potiuk mentioned this issue Jul 6, 2023
Merged
potiuk added a commit to potiuk/airflow that referenced this issue Jul 6, 2023
@potiuk
Limit click until we fix mypy issues
acf35c4 
Click 8.1.4 breaks our mypy checks. The upper limit can be lifted when
the apache#32412 issue is resolved
potiuk added a commit that referenced this issue Jul 6, 2023
@potiuk
Limit click until we fix mypy issues (#32413)
bb97bf2 
Click 8.1.4 breaks our mypy checks. The upper limit can be lifted when
the #32412 issue is resolved
ephraimbuddy pushed a commit that referenced this issue Jul 7, 2023
@potiuk @ephraimbuddy
Limit click until we fix mypy issues (#32413)
aa4cda3 
Click 8.1.4 breaks our mypy checks. The upper limit can be lifted when
the #32412 issue is resolved

(cherry picked from commit bb97bf2)
@uranusjr
Copy link
Member

uranusjr commented Jul 7, 2023

Upstream tracking issue: pallets/click#2558

@ephraimbuddy ephraimbuddy mentioned this issue Jul 7, 2023
Closed
53 tasks
@potiuk
Copy link
Member Author

potiuk commented Jul 8, 2023

So, we are not the only ones :)

syedahsn pushed a commit to aws-mwaa/upstream-to-airflow that referenced this issue Jul 11, 2023
@potiuk @syedahsn
Limit click until we fix mypy issues (apache#32413)
85ee689 
Click 8.1.4 breaks our mypy checks. The upper limit can be lifted when
the apache#32412 issue is resolved
@pierrejeambrun pierrejeambrun mentioned this issue Jul 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:meta High-level information important to the community
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove click upper bound pierrejeambrun/airflow
2 participants
@potiuk @uranusjr