Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snowflake connection UI does not hide private_key_content in the Extra field and in the Private key (Text) field #42496

Closed
1 of 2 tasks
TJaniF opened this issue Sep 26, 2024 · 2 comments · Fixed by #42649
Closed
1 of 2 tasks
Labels
area:providers area:UI Related to UI/UX. For Frontend Developers. good first issue kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet provider:snowflake Issues related to Snowflake provider

Comments

@TJaniF
Copy link
Contributor

TJaniF commented Sep 26, 2024

Apache Airflow Provider(s)

snowflake

Versions of Apache Airflow Providers

apache-airflow-providers-snowflake==5.7.1

Apache Airflow version

2.10.2

Operating System

Debian GNU/Linux 12 (bookworm)

Deployment

Astronomer

Deployment details

No response

What happened

Noticed that the private_key_content as well as the Private key (Text) field are not masked upon editing a connection

image

(also the Private key (Text) field displays error and warning icons for valid keys, probably trying to display JSON)

What you think should happen instead

I think it should be masked in the text field and use RATHER_LONG_SENSITIVE_FIELD_PLACEHOLDER in the Extra field
Also it should not display warning icons for a valid key.

How to reproduce

  1. Create a Snowflake connection in the Airflow UI
  2. paste a value in the Private Key (Text) field
  3. Save the connection
  4. Edit the connection
  5. See the key

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@TJaniF TJaniF added area:providers kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Sep 26, 2024
@dosubot dosubot bot added area:UI Related to UI/UX. For Frontend Developers. provider:snowflake Issues related to Snowflake provider labels Sep 26, 2024
@rawwar
Copy link
Collaborator

rawwar commented Oct 2, 2024

@potiuk , wondering if it's possible to hide private_key_content in the Extra field? The only way I see it is by making extra field sensitive.

@potiuk
Copy link
Member

potiuk commented Oct 2, 2024

@potiuk , wondering if it's possible to hide private_key_content in the Extra field? The only way I see it is by making extra field sensitive.

Yes. Your PR implemented what's needed. Will be released in the next snowflake provider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers area:UI Related to UI/UX. For Frontend Developers. good first issue kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet provider:snowflake Issues related to Snowflake provider
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants