move connectionless email depreciation warning

[ITJamie]

depreciation warning was located inside the wrong block.
now it will warn if there is no conn_id assigned

closes: #19805

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https:/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

• Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: [email protected]
  Slack: https://s.apache.org/airflow-slack

[pankajkoti]

I am taking a look at the issue trail and wondering if we only need an else block here with keeping all the existing code as it is.

[uranusjr]

I’d argue the smtp_... = airflow_conn... lines should be moved to the else block as well.

[ITJamie]

I am taking a look at the issue trail and wondering if we only need an else block here with keeping all the existing code as it is.

I dont see how we would do that and be certain that the smtp creds came from the connection and not from the conf file without rework

[eladkal]

Holding till review from @hussein-awala as email/smtp is under refactor.

@hussein-awala can you please review?

[uranusjr]

Why move this one?

[ITJamie]

Because its a valid warning that no creds were supplied in the connection and will be using non authentication smtp

[uranusjr]

No I mean does it not do its job at its original location? Why not?

[ITJamie]

We want it to trigger after ether a connection has been found or failback to airflow.cfg variables have been parsed

So i moved it after the above had been completed

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.