Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datasets): make strict_dataset_uri_validation default to True #41814

Merged

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Aug 28, 2024


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@Lee-W Lee-W force-pushed the make-strict_dataset_uri_validation-to-true branch from 46abf95 to 13101c2 Compare August 28, 2024 02:47
@Lee-W Lee-W added the airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes label Aug 28, 2024
@Lee-W Lee-W added this to the Airflow 3.0.0 milestone Aug 28, 2024
@Lee-W Lee-W force-pushed the make-strict_dataset_uri_validation-to-true branch 2 times, most recently from 7597de2 to 5d6e598 Compare August 28, 2024 07:51
airflow/datasets/__init__.py Outdated Show resolved Hide resolved
@Lee-W Lee-W force-pushed the make-strict_dataset_uri_validation-to-true branch 2 times, most recently from a5006be to 91dbb58 Compare August 28, 2024 08:52
@Lee-W Lee-W force-pushed the make-strict_dataset_uri_validation-to-true branch from 91dbb58 to b1d5042 Compare September 4, 2024 01:05
@Lee-W Lee-W mentioned this pull request Sep 18, 2024
2 tasks
@Lee-W
Copy link
Member Author

Lee-W commented Oct 6, 2024

@Lee-W Lee-W force-pushed the make-strict_dataset_uri_validation-to-true branch from b1d5042 to e7f6d57 Compare October 7, 2024 07:15
@Lee-W Lee-W requested a review from potiuk as a code owner October 7, 2024 09:10
@Lee-W Lee-W force-pushed the make-strict_dataset_uri_validation-to-true branch 2 times, most recently from 9d96c73 to e4a2cf3 Compare October 7, 2024 13:43
@Lee-W Lee-W force-pushed the make-strict_dataset_uri_validation-to-true branch from e4a2cf3 to 3dd28c3 Compare October 7, 2024 16:15
@Lee-W Lee-W requested a review from uranusjr October 8, 2024 00:45
tests/io/test_path.py Outdated Show resolved Hide resolved
@Lee-W Lee-W merged commit bf46f68 into apache:main Oct 9, 2024
52 checks passed
@Lee-W Lee-W deleted the make-strict_dataset_uri_validation-to-true branch October 9, 2024 10:52
kunaljubce pushed a commit to kunaljubce/airflow that referenced this pull request Oct 13, 2024
…pache#41814)

* feat(datasets): make strict_dataset_uri_validation default to True

* docs(assets): add uri scheme restrict instruction for AIP-60

* feat(assets): add an error logging to URI that is not AIP-60 compliant

* Better test string

---------

Co-authored-by: Tzu-ping Chung <[email protected]>
pavansharma36 pushed a commit to pavansharma36/airflow that referenced this pull request Oct 14, 2024
…pache#41814)

* feat(datasets): make strict_dataset_uri_validation default to True

* docs(assets): add uri scheme restrict instruction for AIP-60

* feat(assets): add an error logging to URI that is not AIP-60 compliant

* Better test string

---------

Co-authored-by: Tzu-ping Chung <[email protected]>
R7L208 pushed a commit to R7L208/airflow that referenced this pull request Oct 17, 2024
…pache#41814)

* feat(datasets): make strict_dataset_uri_validation default to True

* docs(assets): add uri scheme restrict instruction for AIP-60

* feat(assets): add an error logging to URI that is not AIP-60 compliant

* Better test string

---------

Co-authored-by: Tzu-ping Chung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants