Fix SparkKubernetesOperator spark name. #42427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gopidesupavan
requested review from
jedcunningham and
hussein-awala
as code owners
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
gopidesupavan
changed the title
nevcohen
reviewed
Sep 24, 2024
airflow/providers/cncf/kubernetes/operators/spark_kubernetes.py
Outdated
Show resolved
Hide resolved
airflow/providers/cncf/kubernetes/operators/spark_kubernetes.py
Outdated
Show resolved
Hide resolved
nevcohen
reviewed
Sep 24, 2024
updated. |
eladkal
requested review from
nevcohen and
romsharon98
and removed request for
nevcohen
romsharon98
approved these changes
Sep 27, 2024
romsharon98
reviewed
Sep 27, 2024
airflow/providers/cncf/kubernetes/operators/spark_kubernetes.py
Outdated
Show resolved
Hide resolved
romsharon98
reviewed
Sep 27, 2024
airflow/providers/cncf/kubernetes/operators/spark_kubernetes.py
Outdated
Show resolved
Hide resolved
gopidesupavan
deleted the
fix-spark-application-name-in-spark-kuberenetes-operator
branch
96 tasks
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
* use name parameter from spark yaml config or from operator argument parameter * update tests and name usage condition check * adding test, to check spark name starts with task_id * use set_name function in create_job * remove lower
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it's ignoring the name from both the YAML file and operator arguments, and always using the task ID as the name by default, with random suffix.
The name precedence order follows like below:
Should we switch the first two steps, or does this order make sense?
closes: #41188
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.