Refactor bucket.get_blob calls in GCSHook to handle validation for non-existent objects.
#42474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-existing files.
boring-cyborg
bot
added
area:providers
provider:google
|
Hi @shahar1, my PR is ready. I noticed that several methods in the GCS hook have the same issue as get_size, and some of them implemented nonexistent file checking too, so I decided to refactor those methods to reduce redundancy. Kindly check the PR when you have time. |
shahar1
reviewed
Sep 25, 2024
There was a problem hiding this comment.
Good start! Few comments:
- If you decide to solve the deeper cause of the original issue (which is great!) - please refer to it directly in the PR: title, content and newsfragment (i.e., fixing the issue in the hooks that tilize
get_blob, rather than the operator). It still closes the original issue though. - There are 2 failing tests due to the refactoring, try to fix these tests.
There's also an inline comment :)
jsjasonseba
changed the title
GCSToLocalFilesystemOperator when reading non-existing filesbucket.get_blob calls in GCSHook to handle validation for non-existent objects.
jsjasonseba
changed the title
bucket.get_blob calls in GCSHook to handle validation for non-existent objects.bucket.get_blob calls in GCSHook to handle validation for non-existent objects.
shahar1
approved these changes
Sep 27, 2024
|
Great work! |
96 tasks
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
…n for non-existent objects. (apache#42474) * Fix implicit exception in GCSToLocalFilesystemOperator when reading non-existing files. * change method to internal method * Fix unit test expectations * Refactor bucket.get_blob calls in GCSHook to handle validation for non-existent objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #42439
related: #42439
This PR refactors
bucket.get_blobcalls inGCSHookto handle validation for non-existent objects. An internal method named_get_blobis created inGCSHookto consolidatebucket.get_blobcalls where it includes validation. Exception is raised when object is non-existent.It also fixes implicit exception in
GCSToLocalFilesystemOperatorwhen reading non-existing files by raising an explicit exception indicating object non-existence.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.