Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIP-84 Migrate GET Dag Run endpoint to FastAPI #42725

Merged
merged 25 commits into from
Oct 10, 2024
Merged

AIP-84 Migrate GET Dag Run endpoint to FastAPI #42725

merged 25 commits into from
Oct 10, 2024

Conversation

rawwar
Copy link
Collaborator

@rawwar rawwar commented Oct 4, 2024

related to: #42701

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Oct 4, 2024
@rawwar rawwar mentioned this pull request Oct 4, 2024
Open
11 tasks
@rawwar rawwar closed this Oct 4, 2024
@rawwar rawwar reopened this Oct 4, 2024
@rawwar rawwar marked this pull request as ready for review October 4, 2024 16:00
@rawwar rawwar mentioned this pull request Oct 7, 2024
Closed
@rawwar

This comment has been minimized.

Sign in to view
@gopidesupavan gopidesupavan added the legacy api Whether legacy API changes should be allowed in PR label Oct 8, 2024
pierrejeambrun
pierrejeambrun reviewed Oct 9, 2024
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

A few minor suggestions, then we can merge :). Needs rebase re-rerun code gen

airflow/api_fastapi/views/public/dag_run.py Outdated Show resolved Hide resolved
tests/api_fastapi/views/public/test_dag_run.py Show resolved Hide resolved
pierrejeambrun
pierrejeambrun reviewed Oct 9, 2024
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know when you added the 404 tests. Looking good overall, minor suggestion.

@rawwar
Copy link
Collaborator Author

rawwar commented Oct 9, 2024

Let me know when you added the 404 tests. Looking good overall, minor suggestion.

I've added a test for 404.

@rawwar rawwar mentioned this pull request Oct 9, 2024
Closed
4 tasks
@pierrejeambrun pierrejeambrun merged commit efcb554 into apache:main Oct 10, 2024
52 checks passed
@pierrejeambrun pierrejeambrun mentioned this pull request Oct 10, 2024
Merged
kunaljubce pushed a commit to kunaljubce/airflow that referenced this pull request Oct 13, 2024
@rawwar @pierrejeambrun @kunaljubce
AIP-84 Migrate GET Dag Run endpoint to FastAPI (apache#42725)
24fbcd5 
* get dag_run init

* add serializer

* Merge branch 'main' of https:/apache/airflow into kalyan/AIP-84/get_dag_run

* add types

* add test

* working tests

* add note to DagRunResponse

* add note

* add test to test non Null note

* Update airflow/api_fastapi/views/public/dag_run.py

Co-authored-by: Pierre Jeambrun <[email protected]>

* Update airflow/api_fastapi/views/public/dag_run.py

Co-authored-by: Pierre Jeambrun <[email protected]>

* Merge branch 'main' of https:/apache/airflow into kalyan/AIP-84/get_dag_run

* add 404 test

---------

Co-authored-by: Pierre Jeambrun <[email protected]>
pavansharma36 pushed a commit to pavansharma36/airflow that referenced this pull request Oct 14, 2024
@rawwar @pierrejeambrun @pavansharma36
AIP-84 Migrate GET Dag Run endpoint to FastAPI (apache#42725)
a56c052 
* get dag_run init

* add serializer

* Merge branch 'main' of https:/apache/airflow into kalyan/AIP-84/get_dag_run

* add types

* add test

* working tests

* add note to DagRunResponse

* add note

* add test to test non Null note

* Update airflow/api_fastapi/views/public/dag_run.py

Co-authored-by: Pierre Jeambrun <[email protected]>

* Update airflow/api_fastapi/views/public/dag_run.py

Co-authored-by: Pierre Jeambrun <[email protected]>

* Merge branch 'main' of https:/apache/airflow into kalyan/AIP-84/get_dag_run

* add 404 test

---------

Co-authored-by: Pierre Jeambrun <[email protected]>
R7L208 pushed a commit to R7L208/airflow that referenced this pull request Oct 17, 2024
@rawwar @pierrejeambrun
AIP-84 Migrate GET Dag Run endpoint to FastAPI (apache#42725)
78b5a01 
* get dag_run init

* add serializer

* Merge branch 'main' of https:/apache/airflow into kalyan/AIP-84/get_dag_run

* add types

* add test

* working tests

* add note to DagRunResponse

* add note

* add test to test non Null note

* Update airflow/api_fastapi/views/public/dag_run.py

Co-authored-by: Pierre Jeambrun <[email protected]>

* Update airflow/api_fastapi/views/public/dag_run.py

Co-authored-by: Pierre Jeambrun <[email protected]>

* Merge branch 'main' of https:/apache/airflow into kalyan/AIP-84/get_dag_run

* add 404 test

---------

Co-authored-by: Pierre Jeambrun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierrejeambrun pierrejeambrun pierrejeambrun approved these changes

@bbovenzi bbovenzi Awaiting requested review from bbovenzi bbovenzi is a code owner

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@jscheffl jscheffl Awaiting requested review from jscheffl jscheffl is a code owner

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

@kaxil kaxil Awaiting requested review from kaxil

@ashb ashb Awaiting requested review from ashb

@bolkedebruin bolkedebruin Awaiting requested review from bolkedebruin

Assignees
No one assigned
Labels
area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. legacy api Whether legacy API changes should be allowed in PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rawwar @bbovenzi @pierrejeambrun @gopidesupavan