Remove airflow_version from k8s executor pod selector #42751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is a task running and upgrade in flight then there will be version mismatch. So we should not include the airflow version in the selector.
dstandish
requested review from
jedcunningham and
hussein-awala
as code owners
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
jedcunningham
approved these changes
Oct 4, 2024
hussein-awala
approved these changes
Oct 4, 2024
Closed
2 tasks
Closed
2 tasks
jscheffl
pushed a commit
to potiuk/airflow
that referenced
this pull request
Oct 5, 2024
The apache#42751 removed airflow_version from k8s log handler and apparently some tests in tests_utils still use kubernetes provider and k8s test handler. Also it turned out some other tests used Celery Executor as well. Fixed the tests and move them to K8S / Celery provider respectively.
jscheffl
pushed a commit
to jscheffl/airflow
that referenced
this pull request
Oct 5, 2024
The apache#42751 removed airflow_version from k8s log handler and apparently some tests in tests_utils still use kubernetes provider and k8s test handler. Also it turned out some other tests used Celery Executor as well. Fixed the tests and move them to K8S / Celery provider respectively.
jscheffl
added a commit
that referenced
this pull request
Oct 5, 2024
* Fix failing log test handler tests The #42751 removed airflow_version from k8s log handler and apparently some tests in tests_utils still use kubernetes provider and k8s test handler. Also it turned out some other tests used Celery Executor as well. Fixed the tests and move them to K8S / Celery provider respectively. * Attempt to fix side-effect from other tests logging config * Fix Task Log Handler for Celery * Fix SQL Hook Test * Skip task log handler in Airflow 2.8 * set try number in celeryexecutor test * remove skipif --------- Co-authored-by: Jarek Potiuk <[email protected]> Co-authored-by: Jens Scheffler <[email protected]>
96 tasks
kunaljubce
pushed a commit
to kunaljubce/airflow
that referenced
this pull request
Oct 13, 2024
* Fix failing log test handler tests The apache#42751 removed airflow_version from k8s log handler and apparently some tests in tests_utils still use kubernetes provider and k8s test handler. Also it turned out some other tests used Celery Executor as well. Fixed the tests and move them to K8S / Celery provider respectively. * Attempt to fix side-effect from other tests logging config * Fix Task Log Handler for Celery * Fix SQL Hook Test * Skip task log handler in Airflow 2.8 * set try number in celeryexecutor test * remove skipif --------- Co-authored-by: Jarek Potiuk <[email protected]> Co-authored-by: Jens Scheffler <[email protected]>
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
When there is a task running and upgrade in flight then there will be version mismatch. So we should not include the airflow version in the selector.
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
* Fix failing log test handler tests The apache#42751 removed airflow_version from k8s log handler and apparently some tests in tests_utils still use kubernetes provider and k8s test handler. Also it turned out some other tests used Celery Executor as well. Fixed the tests and move them to K8S / Celery provider respectively. * Attempt to fix side-effect from other tests logging config * Fix Task Log Handler for Celery * Fix SQL Hook Test * Skip task log handler in Airflow 2.8 * set try number in celeryexecutor test * remove skipif --------- Co-authored-by: Jarek Potiuk <[email protected]> Co-authored-by: Jens Scheffler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is a task running and upgrade in flight then there will be version mismatch. So we should not include the airflow version in the selector.