Remove dag.run() method #42761
Merged
Remove dag.run() method #42761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:dev-tools
area:Executors-core
|
🧛 |
potiuk
reviewed
Oct 5, 2024
dstandish
force-pushed
the
aip-78-remove-DAG-run-method
branch
from
847cfcd
to
74c22aa
Compare
dstandish
force-pushed
the
aip-78-remove-DAG-run-method
branch
2 times, most recently
from
e07e652
to
0f1eb90
Compare
dstandish
added
the
full tests needed
dstandish
force-pushed
the
aip-78-remove-DAG-run-method
branch
3 times, most recently
from
01a235e
to
d74c9ea
Compare
dstandish
removed
the
full tests needed
dstandish
force-pushed
the
aip-78-remove-DAG-run-method
branch
from
d74c9ea
to
7f1a3c6
Compare
dstandish
requested review from
XD-DENG,
ashb,
o-nikolas,
pierrejeambrun and
hussein-awala
as code owners
dstandish
force-pushed
the
aip-78-remove-DAG-run-method
branch
4 times, most recently
from
2e158aa
to
c0d2b0d
Compare
ashb
reviewed
Oct 10, 2024
providers/src/airflow/providers/google/marketing_platform/example_dags/example_display_video.py
Show resolved
Hide resolved
providers/tests/google/cloud/transfers/test_facebook_ads_to_gcs_system.py
Outdated
Show resolved
Hide resolved
providers/tests/system/google/cloud/dataprep/example_dataprep.py
Outdated
Show resolved
Hide resolved
kaxil
reviewed
Oct 10, 2024
kaxil
approved these changes
Oct 10, 2024
dstandish
force-pushed
the
aip-78-remove-DAG-run-method
branch
2 times, most recently
from
a727814
to
20c6a70
Compare
dstandish
requested review from
ryanahamilton,
bbovenzi and
jscheffl
as code owners
dstandish
force-pushed
the
aip-78-remove-DAG-run-method
branch
from
9c3842a
to
fd1ff94
Compare
kunaljubce
pushed a commit
to kunaljubce/airflow
that referenced
this pull request
Oct 13, 2024
This method uses Backfill internally. Before we can remove BackfillJobRunner, we need to remove DAG.run. But before we can remove DAG.run, we need to update some old tests that use it. So this is the first step towards removing BackflilJobRunner. There were some very old tests that came from airflow github issue 1225. These appeared to test the scheduler but really they tested the backfill job runner. Just to be cautious, I kept most of them rather than remove (which probably would have been fine since they essentially tested code that we'll be removing). As appropriate I either changed them to run on dag.test or scheduler. The ones dealing with ignore first depends on past will have to be added back when that functionality is implemented in new backfill.
pavansharma36
pushed a commit
to pavansharma36/airflow
that referenced
this pull request
Oct 14, 2024
This method uses Backfill internally. Before we can remove BackfillJobRunner, we need to remove DAG.run. But before we can remove DAG.run, we need to update some old tests that use it. So this is the first step towards removing BackflilJobRunner. There were some very old tests that came from airflow github issue 1225. These appeared to test the scheduler but really they tested the backfill job runner. Just to be cautious, I kept most of them rather than remove (which probably would have been fine since they essentially tested code that we'll be removing). As appropriate I either changed them to run on dag.test or scheduler. The ones dealing with ignore first depends on past will have to be added back when that functionality is implemented in new backfill.
R7L208
pushed a commit
to R7L208/airflow
that referenced
this pull request
Oct 17, 2024
This method uses Backfill internally. Before we can remove BackfillJobRunner, we need to remove DAG.run. But before we can remove DAG.run, we need to update some old tests that use it. So this is the first step towards removing BackflilJobRunner. There were some very old tests that came from airflow github issue 1225. These appeared to test the scheduler but really they tested the backfill job runner. Just to be cautious, I kept most of them rather than remove (which probably would have been fine since they essentially tested code that we'll be removing). As appropriate I either changed them to run on dag.test or scheduler. The ones dealing with ignore first depends on past will have to be added back when that functionality is implemented in new backfill.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method uses Backfill internally. Before we can remove BackfillJobRunner, we need to remove DAG.run. But before we can remove DAG.run, we need to update some old tests that use it. So this is the first step towards removing BackflilJobRunner.
There were some very old tests that came from airflow github issue 1225. These appeared to test the scheduler but really they tested the backfill job runner. Just to be cautious, I kept most of them rather than remove (which probably would have been fine since they essentially tested code that we'll be removing). As appropriate I either changed them to run on dag.test or scheduler. The ones dealing with ignore first depends on past will have to be added back when that functionality is implemented in new backfill.