Use url_from_endpoint inside HttpHook. #42785
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
url_from_endpoint
was removed at #37696 and returned back later at #37738. Is there any reason to not use theurl_from_endpoint
inside HttpHook? That way it can be overriden in other hooks based on HttpHook to enhance URL building logic. In my case, I would like to append api key to the end of the url as query parameter.