Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix PyDocStyle checks #42841

Merged
merged 6 commits into from
Oct 9, 2024
Merged

fix PyDocStyle checks #42841

merged 6 commits into from
Oct 9, 2024

Conversation

dannyl1u
Copy link
Contributor

@dannyl1u dannyl1u commented Oct 8, 2024

related: #40567
PT004 | Fixture does not return anything, add leading underscore
Reduces PT004 errors from 345 to 318.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Oct 8, 2024
@dannyl1u dannyl1u marked this pull request as draft October 8, 2024 21:07
@dannyl1u dannyl1u marked this pull request as ready for review October 9, 2024 17:49
Copy link
Contributor

@ferruzzi ferruzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

views.py will be removed in 3.0 do actually this PR improves testing in almost dead code... but anyway still improves :-D

@ferruzzi ferruzzi merged commit 51f6e2f into apache:main Oct 9, 2024
49 checks passed
@dannyl1u dannyl1u deleted the pydocstylechecks branch October 9, 2024 18:42
kunaljubce pushed a commit to kunaljubce/airflow that referenced this pull request Oct 13, 2024
pavansharma36 pushed a commit to pavansharma36/airflow that referenced this pull request Oct 14, 2024
R7L208 pushed a commit to R7L208/airflow that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants