AIP-84 Fix dag display name search #42863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just pushing a test case update that will actually break without that extra piece of code. (dag_dispaly_name is not set, and the porperty is then defaulting to the |
pierrejeambrun
force-pushed
the
fix-dag-display-name-search-hybrid-property
branch
from
e8aa602
to
955874b
Compare
bbovenzi
approved these changes
Oct 9, 2024
pierrejeambrun
force-pushed
the
fix-dag-display-name-search-hybrid-property
branch
2 times, most recently
from
3010ff7
to
84eac3d
Compare
pierrejeambrun
force-pushed
the
fix-dag-display-name-search-hybrid-property
branch
from
84eac3d
to
499d450
Compare
pierrejeambrun
deleted the
fix-dag-display-name-search-hybrid-property
branch
kunaljubce
pushed a commit
to kunaljubce/airflow
that referenced
this pull request
Oct 13, 2024
* Fix dag display name search * Fix CI
pavansharma36
pushed a commit
to pavansharma36/airflow
that referenced
this pull request
Oct 14, 2024
* Fix dag display name search * Fix CI
R7L208
pushed a commit
to R7L208/airflow
that referenced
this pull request
Oct 17, 2024
* Fix dag display name search * Fix CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the dag display name search.
I had that property.expression at some point and figured it wasn't necessary anymore because tests were green even when I removed it. Apparently it was still required :)