Add search by dag_display_name_pattern on dag list page with rebase #42896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luyangliuable
requested review from
bbovenzi,
pierrejeambrun,
ryanahamilton and
jscheffl
as code owners
luyangliuable
changed the title
|
Looks like we need to run |
|
Thanks, I ran |
bbovenzi
reviewed
Oct 11, 2024
Co-authored-by: Brent Bovenzi <[email protected]>
… and adding debounced search logic.
luyangliuable
force-pushed
the
feature/search-by-dag-display-name-pattern-rebase2
branch
from
02852da
to
78153aa
Compare
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
R7L208
pushed a commit
to R7L208/airflow
that referenced
this pull request
Oct 17, 2024
…pache#42896) * Add search by `dag_display_name_pattern` on dag list page. * refactor search parameter update logic * Refactor SearchBar component and simplify debounce logic in DagsList. * Refactor search input change handling for SearchBar and DagsList components * Update airflow/ui/src/pages/DagsList/DagsList.tsx Co-authored-by: Brent Bovenzi <[email protected]> * Refactor search parameter handling and improve type consistency * Remove typo * Add `LAST_DAG_RUN_STATE` to `SearchParamsKeys` and update filters * Add LAST_DAG_RUN_STATE to SearchParamsKeys and update filters * Fix missing change for add SearchBar component by removing forwardRef and adding debounced search logic. * minor change for SearchBar and DagsFilters components * Optimize imports and improve formatting across components * refactor: move query options from autogenerated useDagServiceGetDags to DagsList. * Fix formatting. --------- Co-authored-by: Brent Bovenzi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PR after rebase for #42797
Screen.Recording.2024-10-08.at.12.55.23.am.mov
dagDisplayNamePattern. If this is not desirable, I can remove it.searchParams.ts.There are a few issues to address:
dagDisplayNamePatterndoes not accurately find or include the DAGs when the text matches the tag name exactly. The reason for this is unclear.DagsListbased onisLoading, as it was causing the entireDagsListcomponent to re-render every time the data was updated.Closes: https:/apache/airflow/issues/27581