Fix PythonOperator DAG error when DAG has hyphen in name

[jason810496]

closes: #42796

After reproducing the issue, I found that the generated DAG file looks like this:

import types

unusual_prefix_3f65a6a886883f41209c142108053b32fdfbaf99_my-dag  = types.ModuleType("unusual_prefix_3f65a6a886883f41209c142108053b32fdfbaf99_my-dag")

unusual_prefix_3f65a6a886883f41209c142108053b32fdfbaf99_my-dag.callable_virtualenv = callable_virtualenv

sys.modules["unusual_prefix_3f65a6a886883f41209c142108053b32fdfbaf99_my-dag"] = unusual_prefix_3f65a6a886883f41209c142108053b32fdfbaf99_my-dag

# ...

Replace the hyphen with dash in original module name to solve this issue.

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https:/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

• Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
• Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: [email protected]
  Slack: https://s.apache.org/airflow-slack

[josix]

question: I'm wondering if only hyphen character could be causing this issue. Do we have a more general way to prevent this bug from happening?

[jason810496]

If we directly hash the original module name, it will definitely work.
However, I think it's better to convert characters that could be interpreted as Python operators (like . or -) into underscores.The original module name is derived from the DAG file name by using rfind to remove the file extension.
The original developer probably intended to retain some readability.

[Lee-W]

Left on nitpick. I think we're really close to merge.

[Lee-W]

Looks good to me. Will merge it once CI pass

[boring-cyborg]

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

[Lee-W]

@jason810496 congrate on your first PR 🙂 I think this can be back ported to 2.10.x. Could you please open a PR based on branch v2-10-test