-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple "Task Execution API" server #43015
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbovenzi
reviewed
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
ashb
reviewed
Oct 15, 2024
kaxil
commented
Oct 15, 2024
kaxil
changed the title
Add simple "Task API" server
Add simple "Task Execution API" server
Oct 15, 2024
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Oct 15, 2024
This is part of the change I want to do for apache#43015 but going to break it down to keep it manageable.
kaxil
added a commit
that referenced
this pull request
Oct 15, 2024
This is part of the change I want to do for #43015 but going to break it down to keep it manageable. Since these are actual routes for APIs, renaming them to routes instead of views.
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Oct 16, 2024
In preparation for adding apache#43015, this PRs re-organizes the ``api_fastapi``. The goal will be to have 2 apps: `execution_api` (Task Execution API: AIP-72) and the `core_api` (UI and Public APi).
closes apache#43009 The Task Execution API is created as a separate FastAPI APP so that it allows us to hook CLI and selectively run the "Execution API" with the rest of Airflow API (UI/public). This is so that users can scale the APIs separately if needed as mentioned in apache#43009
pierrejeambrun
approved these changes
Oct 17, 2024
R7L208
pushed a commit
to R7L208/airflow
that referenced
this pull request
Oct 17, 2024
This is part of the change I want to do for apache#43015 but going to break it down to keep it manageable. Since these are actual routes for APIs, renaming them to routes instead of views.
R7L208
pushed a commit
to R7L208/airflow
that referenced
this pull request
Oct 17, 2024
closes apache#43009 The Task Execution API is created as a separate FastAPI APP so that it allows us to hook CLI and selectively run the "Execution API" with the rest of Airflow API (UI/public). This is so that users can scale the APIs separately if needed as mentioned in apache#43009
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #43009
The Task Execution API is created as a separate FastAPI APP so that it allows us to hook CLI and selectively run the "Execution API" with the rest of Airflow API (UI/public). This is so that users can scale the APIs separately if needed as mentioned in #43009
Depends on:
api_fastapi
folder into apps #43062^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.