add lowerbound to requests-toolbelt and replace requests_toolbelt with requests-toolbelt #43020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h requests-toolbelt
…cicd/requests-toolbelt_lowerbound
rawwar
changed the title
Package names are normalized (approved in PEP 503 - https://packaging.python.org/en/latest/specifications/name-normalization/#name-normalization) - see Normalization specification - https://packaging.python.org/en/latest/specifications/name-normalization/#name-normalization The two names are equivalent but we want to use the "normalized" name, so the change is perfectly fine. |
potiuk
approved these changes
Oct 15, 2024
R7L208
pushed a commit
to R7L208/airflow
that referenced
this pull request
Oct 17, 2024
…h requests-toolbelt (apache#43020)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #42989
I noticed that we included
requests_toolbeltinstead ofrequests-toolbeltin http provider.I thought both downloaded different packages. So, i did a
pip download requests_toolbelt --no-cache-dirand compared its checksum withpip download requests-toolbelt --no-cache-dirand both were same.Not sure if there's no difference between a -(hyphen) and _(underscore) when downloading/installing packages. Officially, its
requests-toolbeltaccording to pypi - https://pypi.org/project/requests-toolbelt/