Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vertex ai training operators: add display_name to rendered fields #43028

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

WSHoekstra
Copy link
Contributor


Add display_name and model_display_name to list of rendered fields for Vertex AI operators.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Oct 15, 2024
Copy link

boring-cyborg bot commented Oct 15, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https:/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@potiuk potiuk linked an issue Oct 15, 2024 that may be closed by this pull request
2 tasks
@potiuk
Copy link
Member

potiuk commented Oct 15, 2024

For the future - you can add "Closes: #ISSUE_NUMBER" to the commit message and it will automatically link the issue you created and it will close it - saves a lot of duplicated effort.

Also - for such things we do not really need an issue - just open PR and add description what it does - we do not really like overhead and unnecessary beauracracy 😄

@shahar1 shahar1 force-pushed the vertex-ai-render-display-name branch from f698fd3 to 4a55c3c Compare October 17, 2024 06:35
Copy link
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
There was a static check error due to current limitations of the validate-operators-init static check: the templated fields should be defined in the constructor's signature and explicitly assigned via super().__init__(param=param, ...) or self.param = params - even in inherited classes.
I rebased and pushed the fix.

@shahar1 shahar1 force-pushed the vertex-ai-render-display-name branch from 4a55c3c to 2d01221 Compare October 17, 2024 07:10
@shahar1 shahar1 merged commit f587edf into apache:main Oct 17, 2024
55 checks passed
Copy link

boring-cyborg bot commented Oct 17, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

R7L208 pushed a commit to R7L208/airflow that referenced this pull request Oct 17, 2024
…ache#43028)

* vertex ai training operators: add display_name to rendered fields

* fix validate-operators-init static checks

---------

Co-authored-by: Walter Hoekstra <[email protected]>
Co-authored-by: Shahar Epstein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add display_name to rendered fields for Vertex AI training operators
3 participants