Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): add required import of BranchDayOfWeekOperator #43053

Merged

Conversation

sfirke
Copy link
Member

@sfirke sfirke commented Oct 15, 2024

I was following the docs here: https://airflow.apache.org/docs/apache-airflow/stable/_api/airflow/operators/weekday/index.html and adapting those two code blocks. It failed because I didn't import BranchDayOfWeekOperator. So I'm adding it here. Let me know if that does not follow the project's standards.

Copy link

boring-cyborg bot commented Oct 15, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https:/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@potiuk
Copy link
Member

potiuk commented Oct 16, 2024

There is a bug added in recent changes that makes this PR fail - let me fix it and I will ask you to rebase it (missing provider)

Also before you rebase - I recommend installing pre-commit - then it will fix the static check issue automaticaly.

@kaxil
Copy link
Member

kaxil commented Oct 16, 2024

There is a bug added in recent changes that makes this PR fail - let me fix it and I will ask you to rebase it (missing provider)

Also before you rebase - I recommend installing pre-commit - then it will fix the static check issue automaticaly.

It is fixed in #43071 . Once that is merged, please rebase on main and docs should start building again :)

@sfirke sfirke force-pushed the sfirke-add-import-for-branchdayofweekoperator branch from 1571cb7 to 1db6ae3 Compare October 16, 2024 16:35
@potiuk potiuk force-pushed the sfirke-add-import-for-branchdayofweekoperator branch from 1db6ae3 to c483ddb Compare October 16, 2024 21:52
@shahar1 shahar1 force-pushed the sfirke-add-import-for-branchdayofweekoperator branch from c483ddb to 705f4c9 Compare October 17, 2024 12:18
@shahar1
Copy link
Contributor

shahar1 commented Oct 17, 2024

Rebased and fixed a linting error

@potiuk potiuk merged commit 2ed06d1 into apache:main Oct 17, 2024
55 checks passed
Copy link

boring-cyborg bot commented Oct 17, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@sfirke sfirke deleted the sfirke-add-import-for-branchdayofweekoperator branch October 17, 2024 13:58
@sfirke
Copy link
Member Author

sfirke commented Oct 17, 2024

Thanks for fixing my linting 🙏 I did this change in the GitHub web UI but will make future contributions using a proper dev environment.

R7L208 pushed a commit to R7L208/airflow that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants