Fix typo in pyproject.toml #43077
Merged
Fix typo in pyproject.toml #43077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
approved these changes
Oct 16, 2024
vincbeck
approved these changes
Oct 16, 2024
kaxil
added
the
changelog:skip
|
This should have changed the import position via ruff. Something else might be going wrong. |
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Oct 16, 2024
For some reasons apache#43077 passed but main was failing. This PR fixes it.
|
@kaxil - @ashb - this one passed because it only triggered "basic checks" - pyproject.toml "non-dependencies" change is not considered as "source file change". Which maybe it should. I also see that "test_common" should be added as sources in selective checks to trigger tests when only test_common files change. PR is coming |
kaxil
added a commit
that referenced
this pull request
Oct 16, 2024
For some reasons #43077 passed but main was failing. This PR fixes it.
|
Fix to avoid it in the future #43088 |
R7L208
pushed a commit
to R7L208/airflow
that referenced
this pull request
Oct 17, 2024
R7L208
pushed a commit
to R7L208/airflow
that referenced
this pull request
Oct 17, 2024
For some reasons apache#43077 passed but main was failing. This PR fixes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.