Revert "Fix flaky test_get_dags in FastAPI routes"
#43108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2b21e88.
kaxil
approved these changes
Oct 17, 2024
|
Damn -- missed the order_by's |
|
Damn... |
R7L208
pushed a commit
to R7L208/airflow
that referenced
this pull request
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #43100
This should be reverted because:
order_byquery parameters. (The returned items must follow the queried order)get_dagsendpoints but any endpoint returning a list, because the database natural order is not guarantee. (based on insertion etc, etc,). This happens in case of equality on the first order_by criteria.A fix is already opened here #43085. It was there in the first place but got removed by mistake in a recent PR (yesterday or the day before that). To my knowledge we didn't have any issue reported before that.