Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fromarrow(::Type{Dates.Time}, x::Arrow.Time) #527

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fromarrow(::Type{Dates.Time}, x::Arrow.Time) #527

wants to merge 2 commits into from
+9 −1

Conversation

palday
Copy link

@palday palday commented Sep 25, 2024

ericphanson
ericphanson reviewed Oct 11, 2024
View reviewed changes
Copy link
Member

@ericphanson ericphanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is different here from

ArrowTypes.fromarrow(::Type{Dates.Date}, x::DATE) = convert(Dates.Date, x)

above? Or is that method wrong too?

@ericphanson
Copy link
Member

ahh, I get it, we are just dropping a type parameter, TIME is Arrow.Time with a specific eltype. Ok this seems fine to me!

@palday
Copy link
Author

palday commented Oct 11, 2024

That method is probably wrong too

@ericphanson
Copy link
Member

do you want to fix that one too? Or file an issue?

@palday
Copy link
Author

palday commented Oct 11, 2024

Might as well fix it too while I'm at -- I'll update it shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericphanson ericphanson ericphanson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@palday @ericphanson