Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Build arrow-format and arrow-vector as JPMS modules #38997

Closed
jduo opened this issue Nov 30, 2023 · 0 comments · Fixed by #38995
Closed

[Java] Build arrow-format and arrow-vector as JPMS modules #38997

jduo opened this issue Nov 30, 2023 · 0 comments · Fixed by #38995
Assignees
@jduo
Labels
Component: Java Type: enhancement

Comments

@jduo
Copy link
Member

jduo commented Nov 30, 2023 •
edited
Loading

Describe the enhancement requested

This depends on #38998 and #39134 .

Build the first set of core arrow dependencies as JPMS modules while retaining JDK 8 support.

Note that arrow-vector is effectively unusable without also modularizing arrow-memory-core. Vector allocations call into arrow-memory-core's MemoryUtil class which relies on Unsafe.

Component(s)

Java
This was referenced Nov 30, 2023
Closed
Open
@github-actions github-actions bot mentioned this issue Nov 30, 2023
Merged
@jduo jduo mentioned this issue Nov 30, 2023
Merged
jduo added a commit that referenced this issue Jan 11, 2024
@jduo
GH-38997: [Java] Modularize format and vector (#38995)
1a622ec 
### Rationale for this change
This PR depends on #39011 .

Make arrow-vector and arrow-format JPMS modules for improved
compatibility with newer JDKs and tools that require modules.

### What changes are included in this PR?
* add module-info.java files for vector and format.

### Are these changes tested?
Yes, these modules are run as JPMS modules in JDK9+ unit tests.

### Are there any user-facing changes?
Yes, some test classes have moved and users can now run these as JPMS
modules.

* Closes: #38997
clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
@jduo @clayburn
apacheGH-38997: [Java] Modularize format and vector (apache#38995)
f63e900 
### Rationale for this change
This PR depends on apache#39011 .

Make arrow-vector and arrow-format JPMS modules for improved
compatibility with newer JDKs and tools that require modules.

### What changes are included in this PR?
* add module-info.java files for vector and format.

### Are these changes tested?
Yes, these modules are run as JPMS modules in JDK9+ unit tests.

### Are there any user-facing changes?
Yes, some test classes have moved and users can now run these as JPMS
modules.

* Closes: apache#38997
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@jduo @dgreiss
apacheGH-38997: [Java] Modularize format and vector (apache#38995)
5d747f6 
### Rationale for this change
This PR depends on apache#39011 .

Make arrow-vector and arrow-format JPMS modules for improved
compatibility with newer JDKs and tools that require modules.

### What changes are included in this PR?
* add module-info.java files for vector and format.

### Are these changes tested?
Yes, these modules are run as JPMS modules in JDK9+ unit tests.

### Are there any user-facing changes?
Yes, some test classes have moved and users can now run these as JPMS
modules.

* Closes: apache#38997
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
@jduo @zanmato1984
apacheGH-38997: [Java] Modularize format and vector (apache#38995)
3bd7654 
### Rationale for this change
This PR depends on apache#39011 .

Make arrow-vector and arrow-format JPMS modules for improved
compatibility with newer JDKs and tools that require modules.

### What changes are included in this PR?
* add module-info.java files for vector and format.

### Are these changes tested?
Yes, these modules are run as JPMS modules in JDK9+ unit tests.

### Are there any user-facing changes?
Yes, some test classes have moved and users can now run these as JPMS
modules.

* Closes: apache#38997
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
@jduo @thisisnic
apacheGH-38997: [Java] Modularize format and vector (apache#38995)
52b6ddf 
### Rationale for this change
This PR depends on apache#39011 .

Make arrow-vector and arrow-format JPMS modules for improved
compatibility with newer JDKs and tools that require modules.

### What changes are included in this PR?
* add module-info.java files for vector and format.

### Are these changes tested?
Yes, these modules are run as JPMS modules in JDK9+ unit tests.

### Are there any user-facing changes?
Yes, some test classes have moved and users can now run these as JPMS
modules.

* Closes: apache#38997
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jduo jduo

Labels
Component: Java Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-38997: [Java] Modularize format and vector Bit-Quill/arrow
1 participant
@jduo