GH-44461: [Release][Packacing][Python] Set PARQUET_TEST_DATA on verify-release-candidate-wheels.bat #44462

raulcd · 2024-10-17T13:39:57Z

Rationale for this change

The Windows wheel verification fails due to missing PARQUET_TEST_DATA

What changes are included in this PR?

Add PARQUET_TEST_DATA to verify-release-candidate-wheels.bat which is only tested on the binary verification job.

Are these changes tested?

Via archery

Are there any user-facing changes?

No

GitHub Issue: [Packaging][Release][Python] The Windows wheel verification is failing due to missing PARQUET_TEST_DATA env variable #44461

… verify-release-candidate-wheels.bat

github-actions · 2024-10-17T13:40:26Z

⚠️ GitHub issue #44461 has been automatically assigned in GitHub to PR creator.

raulcd · 2024-10-17T13:40:36Z

@github-actions crossbow submit verify-rc-binaries-wheels-windows --param release=18.0.0 --param rc=0

github-actions · 2024-10-17T13:42:54Z

Revision: 6ba7a5a

Submitted crossbow builds: ursacomputing/crossbow @ actions-f980a8883a

Task	Status
verify-rc-binaries-wheels-windows

raulcd · 2024-10-17T13:59:51Z

The error has been fixed but there seems to be a new error with ORC and Timezones :( :

 >       result = dataset_reader.to_table(dataset)
C:\tmp\arrow-verify-release-wheels\_verify-wheel-3.9\Lib\site-packages\pyarrow\tests\test_dataset.py:3248: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
C:\tmp\arrow-verify-release-wheels\_verify-wheel-3.9\Lib\site-packages\pyarrow\tests\test_dataset.py:267: in to_table
    return dataset.to_table(**kwargs)
pyarrow\\_dataset.pyx:562: in pyarrow._dataset.Dataset.to_table
    ???
pyarrow\\_dataset.pyx:3841: in pyarrow._dataset.Scanner.to_table
    ???
pyarrow\\error.pxi:155: in pyarrow.lib.pyarrow_internal_check_status
    ???
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
>   ???
E   pyarrow.lib.ArrowException: Unknown error: Time zone file /usr/share/zoneinfo/UTC does not exist. Please install IANA time zone database and set TZDIR env.
pyarrow\\error.pxi:92: ArrowException

…for nightly wheels verification

raulcd · 2024-10-17T14:03:53Z

@github-actions crossbow submit verify-rc-binaries-wheels-windows --param release=18.0.0 --param rc=0

github-actions · 2024-10-17T14:06:08Z

Revision: 95b3016

Submitted crossbow builds: ursacomputing/crossbow @ actions-5687ee222c

Task	Status
verify-rc-binaries-wheels-windows

raulcd · 2024-10-17T14:16:55Z

dev/release/verify-release-candidate-wheels.bat

+@rem Download IANA Timezone Database for ORC C++
+curl https://cygwin.osuosl.org/noarch/release/tzdata/tzdata-2024a-1.tar.xz --output tzdata.tar.xz || exit /B
+mkdir %USERPROFILE%\Downloads\test\tzdata
+arc unarchive tzdata.tar.xz %USERPROFILE%\Downloads\test\tzdata


arc does not seem to be present:

'arc' is not recognized as an internal or external command, operable program or batch file.

There's some more work to be done here :(

dev/release/verify-release-candidate-wheels.bat

kou · 2024-10-17T21:11:53Z

@github-actions crossbow submit verify-rc-binaries-wheels-windows --param release=18.0.0 --param rc=0

kou · 2024-10-17T22:13:06Z

@github-actions crossbow submit verify-rc-binaries-wheels-windows --param release=18.0.0 --param rc=0

kou · 2024-10-18T00:23:01Z

@github-actions crossbow submit verify-rc-binaries-wheels-windows --param release=18.0.0 --param rc=0

github-actions · 2024-10-18T00:25:15Z

Revision: d43d971

Submitted crossbow builds: ursacomputing/crossbow @ actions-2851110c41

Task	Status
verify-rc-binaries-wheels-windows

kou · 2024-10-18T01:42:55Z

@github-actions crossbow submit verify-rc-binaries-wheels-windows --param release=18.0.0 --param rc=0

github-actions · 2024-10-18T01:45:08Z

Revision: acf0493

Submitted crossbow builds: ursacomputing/crossbow @ actions-628dc0a01d

Task	Status
verify-rc-binaries-wheels-windows

kou · 2024-10-18T02:22:16Z

@github-actions crossbow submit verify-rc-binaries-wheels-windows --param release=18.0.0 --param rc=0

github-actions · 2024-10-18T02:24:36Z

Revision: 6c3e4a5

Submitted crossbow builds: ursacomputing/crossbow @ actions-c2ac566e6f

Task	Status
verify-rc-binaries-wheels-windows

kou · 2024-10-18T02:43:16Z

@github-actions crossbow submit verify-rc-binaries-wheels-windows --param release=18.0.0 --param rc=0

github-actions · 2024-10-18T02:45:28Z

Revision: a753b3b

Submitted crossbow builds: ursacomputing/crossbow @ actions-55cf78c3ae

Task	Status
verify-rc-binaries-wheels-windows

kou · 2024-10-18T03:38:12Z

@github-actions crossbow submit verify-rc-binaries-wheels-windows --param release=18.0.0 --param rc=0

github-actions · 2024-10-18T03:40:29Z

Revision: bc9ff56

Submitted crossbow builds: ursacomputing/crossbow @ actions-ebe4612117

Task	Status
verify-rc-binaries-wheels-windows

kou · 2024-10-18T04:37:22Z

I got it. tzdata 2024b is buggy:

https:/ursacomputing/crossbow/actions/runs/11397027990/job/31711818254#step:5:90

/c/Users/runneradmin/Downloads/tzdata/northamerica:Rule	Mexico	1931	only	-	April	30	0:00	1:00	D

"April" should be "Apr" like other month.

kou · 2024-10-18T04:38:08Z

@github-actions crossbow submit verify-rc-binaries-wheels-windows --param release=18.0.0 --param rc=0

github-actions · 2024-10-18T04:40:26Z

Revision: 2b1cc66

Submitted crossbow builds: ursacomputing/crossbow @ actions-24dbdd9574

Task	Status
verify-rc-binaries-wheels-windows

kou · 2024-10-18T06:30:21Z

@github-actions crossbow submit verify-rc-binaries-wheels-windows --param release=18.0.0 --param rc=0

github-actions · 2024-10-18T06:32:36Z

Revision: 04c0982

Submitted crossbow builds: ursacomputing/crossbow @ actions-07588210a4

Task	Status
verify-rc-binaries-wheels-windows

raulcd · 2024-10-18T06:51:47Z

It seems the new error is what was reported from the conda feedstocks:

[Python][C++] failing tests due to unfound timezones on Windows with 18.0.0-rc0 #44455

kou · 2024-10-18T07:02:36Z

It seems that we need to update bundled datetime...

apacheGH-44461: [Release][Packacing][Python] Set PARQUET_TEST_DATA on…

6ba7a5a

… verify-release-candidate-wheels.bat

github-actions bot added the awaiting committer review Awaiting committer review label Oct 17, 2024

Replicate on Windows wheel release candidate verification what we do …

95b3016

…for nightly wheels verification

raulcd commented Oct 17, 2024

View reviewed changes

github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Oct 17, 2024

kou reviewed Oct 17, 2024

View reviewed changes

dev/release/verify-release-candidate-wheels.bat Outdated Show resolved Hide resolved

Use tar

2ba6b37

github-actions bot added awaiting change review Awaiting change review awaiting changes Awaiting changes and removed awaiting changes Awaiting changes awaiting change review Awaiting change review labels Oct 17, 2024

This comment was marked as outdated.

Sign in to view

Set timeout

0367e95

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Oct 18, 2024

Use zoneinfo by MSYS2

d43d971

Use the latest tzdata

acf0493

Fix URL

6c3e4a5

Debug

a753b3b

Debug

bc9ff56

Use old tzdata again

2b1cc66

Use TZDIR from conda

04c0982

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GH-44461: [Release][Packacing][Python] Set PARQUET_TEST_DATA on verify-release-candidate-wheels.bat #44462

GH-44461: [Release][Packacing][Python] Set PARQUET_TEST_DATA on verify-release-candidate-wheels.bat #44462

raulcd commented Oct 17, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Oct 17, 2024

raulcd commented Oct 17, 2024

github-actions bot commented Oct 17, 2024

raulcd commented Oct 17, 2024

raulcd commented Oct 17, 2024

github-actions bot commented Oct 17, 2024

raulcd Oct 17, 2024

kou commented Oct 17, 2024

This comment was marked as outdated.

kou commented Oct 17, 2024

This comment was marked as outdated.

kou commented Oct 18, 2024

github-actions bot commented Oct 18, 2024

kou commented Oct 18, 2024

github-actions bot commented Oct 18, 2024

kou commented Oct 18, 2024

github-actions bot commented Oct 18, 2024

kou commented Oct 18, 2024

github-actions bot commented Oct 18, 2024

kou commented Oct 18, 2024

github-actions bot commented Oct 18, 2024

kou commented Oct 18, 2024

kou commented Oct 18, 2024

github-actions bot commented Oct 18, 2024

kou commented Oct 18, 2024

github-actions bot commented Oct 18, 2024

raulcd commented Oct 18, 2024

kou commented Oct 18, 2024

GH-44461: [Release][Packacing][Python] Set PARQUET_TEST_DATA on verify-release-candidate-wheels.bat #44462

Are you sure you want to change the base?

GH-44461: [Release][Packacing][Python] Set PARQUET_TEST_DATA on verify-release-candidate-wheels.bat #44462

Conversation

raulcd commented Oct 17, 2024 • edited by github-actions bot Loading

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

github-actions bot commented Oct 17, 2024

raulcd commented Oct 17, 2024

github-actions bot commented Oct 17, 2024

raulcd commented Oct 17, 2024

raulcd commented Oct 17, 2024

github-actions bot commented Oct 17, 2024

raulcd Oct 17, 2024

Choose a reason for hiding this comment

kou commented Oct 17, 2024

This comment was marked as outdated.

kou commented Oct 17, 2024

This comment was marked as outdated.

kou commented Oct 18, 2024

github-actions bot commented Oct 18, 2024

kou commented Oct 18, 2024

github-actions bot commented Oct 18, 2024

kou commented Oct 18, 2024

github-actions bot commented Oct 18, 2024

kou commented Oct 18, 2024

github-actions bot commented Oct 18, 2024

kou commented Oct 18, 2024

github-actions bot commented Oct 18, 2024

kou commented Oct 18, 2024

kou commented Oct 18, 2024

github-actions bot commented Oct 18, 2024

kou commented Oct 18, 2024

github-actions bot commented Oct 18, 2024

raulcd commented Oct 18, 2024

kou commented Oct 18, 2024

raulcd commented Oct 17, 2024 •

edited by github-actions bot

Loading