-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-6142: [R] Install instructions on linux could be clearer #5027
Conversation
Thank you! Other users who have the same question I asked in |
r/R/install-arrow.R
Outdated
@@ -98,7 +98,8 @@ OR_SEE_DEV_GUIDE <- paste0( | |||
SEE_ARROW_INSTALL <- paste( | |||
"See the Apache Arrow project installation page", | |||
"<https://arrow.apache.org/install/>", | |||
"for how to install the C++ package from a PPA." | |||
"to find pre-compiled binary packages for some common Linux distributions,", | |||
"such as Debian, Ubuntu, CentOS, and Fedora." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't provide packages for Fedora yet...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I was blindly following #4948 (comment). Will revise.
Thanks for the clarification @karldw, I misunderstood before. Will add reference to those two packages. |
Revised, PTAL |
r/R/install-arrow.R
Outdated
"for how to install the C++ package from a PPA." | ||
"to find pre-compiled binary packages for some common Linux distributions,", | ||
"including Debian, Ubuntu, and CentOS. You'll need to install 'libarrow-dev'", | ||
"and 'libparquet-dev'." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libarrow-dev
and libparquet-dev
are right package names for Debian and Ubuntu.
But arrow-devel
and parquet-devel
are right package names for CentOS.
BTW, we can install only libparquet-dev
or parquet-devel
because libarrow-dev
and arrow-devel
are automatically installed as dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, revised accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
We can merge this with a small fix. ("arrow" -> "Arrow")
Thanks!
r/R/install-arrow.R
Outdated
"to find pre-compiled binary packages for some common Linux distributions,", | ||
"including Debian, Ubuntu, and CentOS. You'll need to install", | ||
"'libparquet-dev' on Debian and Ubuntu, or 'parquet-devel' on CentOS. This", | ||
"will also automatically install the arrow C++ library as a dependency." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use "Arrow" instead of "arrow"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
I'll merge this when CI is green. |
Here's my fork, which I'm guessing will finish faster: https://travis-ci.org/nealrichardson/arrow/jobs/569137979 |
Codecov Report
@@ Coverage Diff @@
## master #5027 +/- ##
==========================================
- Coverage 87.33% 75.3% -12.03%
==========================================
Files 895 57 -838
Lines 119946 3620 -116326
Branches 1418 0 -1418
==========================================
- Hits 104751 2726 -102025
+ Misses 14833 894 -13939
+ Partials 362 0 -362 Continue to review full report at Codecov.
|
Thanks. CI is green. I'll merge this. |
This updates the language in `install_arrow()` to follow the README revision that will land in https:/apache/arrow/pull/4948/files#diff-563b2cb2c8c2d51b2ff6b177e2d84286R33. The [Jira ticket](https://issues.apache.org/jira/browse/ARROW-6142) requested three things; this is `#2` in the list. On `#1`, I defer to the C++ installation docs, which are already included in the install_arrow message, rather than duplicating content here. `#3` is out of scope. Closes apache#5027 from nealrichardson/no-ppa and squashes the following commits: 80b142e <Neal Richardson> s/arrow/Arrow/ 44c9659 <Neal Richardson> Tweak language again 36cfe28 <Neal Richardson> Further linux install revisions 79bd7e0 <Neal Richardson> One more PPurge 63f75bd <Neal Richardson> Revise install_arrow instructions for Linux Authored-by: Neal Richardson <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
This updates the language in `install_arrow()` to follow the README revision that will land in https:/apache/arrow/pull/4948/files#diff-563b2cb2c8c2d51b2ff6b177e2d84286R33. The [Jira ticket](https://issues.apache.org/jira/browse/ARROW-6142) requested three things; this is `apache#2` in the list. On `apache#1`, I defer to the C++ installation docs, which are already included in the install_arrow message, rather than duplicating content here. `apache#3` is out of scope. Closes apache#5027 from nealrichardson/no-ppa and squashes the following commits: 80b142e <Neal Richardson> s/arrow/Arrow/ 44c9659 <Neal Richardson> Tweak language again 36cfe28 <Neal Richardson> Further linux install revisions 79bd7e0 <Neal Richardson> One more PPurge 63f75bd <Neal Richardson> Revise install_arrow instructions for Linux Authored-by: Neal Richardson <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
This updates the language in
install_arrow()
to follow the README revision that will land in https:/apache/arrow/pull/4948/files#diff-563b2cb2c8c2d51b2ff6b177e2d84286R33.The Jira ticket requested three things; this is
#2
in the list. On#1
, I defer to the C++ installation docs, which are already included in the install_arrow message, rather than duplicating content here.#3
is out of scope.