Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-2.18.0][BEAM-8917] jsr305 dependency declaration for Nullable class (#10324) #10371

Merged
merged 1 commit into from
Dec 13, 2019
Merged

[release-2.18.0][BEAM-8917] jsr305 dependency declaration for Nullable class (#10324) #10371

merged 1 commit into from
Dec 13, 2019

Conversation

iemejia
Copy link
Member

@iemejia iemejia commented Dec 12, 2019

@suztomo @iemejia
[BEAM-8917] jsr305 dependency declaration for Nullable class (apache#…
39e39b6 
…10324)

The Maven artifact org.apache.beam:beam-sdks-java-core, which contains org.apache.beam.sdk.schemas.FieldValueTypeInformation, should declare the dependency to com.google.code.findbugs:jsr305. The class needs Nullable class at runtime.
@iemejia iemejia requested a review from udim December 12, 2019 22:33
udim
udim approved these changes Dec 13, 2019
View reviewed changes
Copy link
Member

@udim udim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Dataflow-based tests fail since this is a release branch, but passed in #10324.

@udim udim merged commit 4b1bfc5 into apache:release-2.18.0 Dec 13, 2019
@iemejia iemejia deleted the release-2.18.0-BEAM-8917 branch December 17, 2019 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@udim udim udim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iemejia @udim @suztomo