Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-12913] Pass query priority from ReadAllFromBigQuery #15584

Merged
merged 2 commits into from
Sep 25, 2021

Conversation

chunyang
Copy link
Contributor

As a followup to #15536, add the query_priority parameter to ReadAllFromBigQuery. This also fixes the broken postcommit tests.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@chunyang
Copy link
Contributor Author

R: @pabloem
R: @y1chi

@chunyang
Copy link
Contributor Author

Run Python 3.7 PostCommit

@pabloem
Copy link
Member

pabloem commented Sep 24, 2021

oops - thanks @chunyang

@pabloem
Copy link
Member

pabloem commented Sep 24, 2021

Run Python 3.8 PostCommit

@chunyang
Copy link
Contributor Author

My bad, I wasn't aware that I could trigger the postcommit tests, will try to remember to do that going forward.

@pabloem
Copy link
Member

pabloem commented Sep 24, 2021

to be fair, I should have known to trigger them before merging. I'll merge once they pass this time

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #15584 (41d9511) into master (9876fe4) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15584      +/-   ##
==========================================
- Coverage   83.77%   83.75%   -0.02%     
==========================================
  Files         444      444              
  Lines       60337    60339       +2     
==========================================
- Hits        50549    50539      -10     
- Misses       9788     9800      +12     
Impacted Files Coverage Δ
sdks/python/apache_beam/io/gcp/bigquery.py 75.56% <0.00%> (-0.12%) ⬇️
...ython/apache_beam/io/gcp/bigquery_read_internal.py 58.15% <0.00%> (-0.32%) ⬇️
sdks/python/apache_beam/io/source_test_utils.py 88.47% <0.00%> (-1.39%) ⬇️
sdks/python/apache_beam/internal/metrics/metric.py 90.42% <0.00%> (-1.07%) ⬇️
...pache_beam/runners/interactive/interactive_beam.py 75.60% <0.00%> (-0.98%) ⬇️
...runners/interactive/display/pcoll_visualization.py 85.85% <0.00%> (-0.51%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.39% <0.00%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9876fe4...41d9511. Read the comment docs.

@pabloem
Copy link
Member

pabloem commented Sep 24, 2021

Run Python 3.8 PostCommit

@pabloem
Copy link
Member

pabloem commented Sep 24, 2021

there seems to be a test that's still broken. It's odd because that test hasn't changed...

https://ci-beam.apache.org/job/beam_PostCommit_Python38_PR/310/testReport/junit/apache_beam.io.gcp.bigquery_read_it_test/ReadAllBQTests/test_read_queries/

@chunyang
Copy link
Contributor Author

chunyang commented Sep 24, 2021

Oh strange, do you know how I can reproduce locally? I am running the following which passes:

pytest apache_beam/io/gcp/bigquery_read_it_test.py::ReadAllBQTests '--test-pipeline-options=<options to enable running on my infra, including: region, project, service_account_email, staging_location, temp_location, subnetwork, sdk_location>'

I'm using the py38-cloud venv (source sdks/python/test-suites/tox/py38/build/srcs/sdks/python/target/.tox-py38-cloud/py38-cloud/bin/activate) inside the build container (./start-build-env.sh)

Copy link
Contributor

@y1chi y1chi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y1chi y1chi merged commit 55b8b8c into apache:master Sep 25, 2021
@chunyang chunyang deleted the cyang/fix-postcommit branch September 25, 2021 03:04
dmitriikuzinepam pushed a commit to dmitriikuzinepam/beam that referenced this pull request Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants