Landscape view - initial refactor #100
Open
+705
−332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with placeholder landscape view (doesn't do any filling, just squarer bits)
ahgittin
force-pushed
the
landscape-view
branch
from
c6e1dec
to
ce5fca3
Compare
|
retest this please |
|
@ahgittin I've tried to build this locally, but I'm getting build errors, and the build is also failing on Jenkins. Can you rebase against master please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the blueprint code to allow dev work on a new "landscape" graphical mode.
It is disabled in the last commit so should be no change to UX with this,
but the other changes should make it easier to work on a landscape view by playing with the sizes of nodes. They refactor much more of the layout-specific logic into subclasses, make the elements being rendered more flexible, and make more of the computations derived from known values.
There is more work to make things like ghost nodes fully derived from the nodes they ghost, which we will need for the landscape view to be able to fill the space but this gets us a good bit of the way there.
If landscape is enabled, it doesn't do what we want, but it has slightly different boxier behaviour to the normal mode to indicate the direction of travel.