Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Set up CodeQL analysis w/ fix #276

Merged
merged 5 commits into from
Apr 17, 2024
Merged

ci: Set up CodeQL analysis w/ fix #276

merged 5 commits into from
Apr 17, 2024

Conversation

erisu
Copy link
Member

@erisu erisu commented Apr 17, 2024

Platforms affected

n/a

Motivation and Context

CodeQL scanning in CI can help identify bugs and security issues with the library.

Description

  • Added CodeQL scanning with default options as part of CI.

Testing

  • Ran this in my fork
  • Confirmed that CodeQL results showed up under security scanning
  • Applied additional non-breaking changes to resolve scan reports.

Checklist

  • I've run the tests to see all new and existing tests pass

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (abe901b) to head (e1cb251).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #276   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          656       656           
=========================================
  Hits           656       656           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erisu erisu merged commit d5ad929 into apache:master Apr 17, 2024
7 checks passed
@erisu erisu deleted the ci/gha-codeql branch April 17, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants