Quick CI fixes #277
Merged
Quick CI fixes #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 31, 2018 18:57
(consistent with test script in package.json)
- skip some platform versions for now - mark FUTURE TBD platform versions
|
What the heck are these changes? Did you do similar commits in other plugin repos? |
janpio
reviewed
Oct 1, 2018
| # osx_image: xcode7.3 | ||
| # language: node_js | ||
| # node_js: '4.2' | ||
| # FUTURE TBD: |
There was a problem hiding this comment.
Something like this should never be in code, only in issues.
janpio
reviewed
Oct 1, 2018
| # - platform-tools | ||
| # - tools | ||
| # - build-tools-26.0.2 | ||
| # FUTURE TBD: |
There was a problem hiding this comment.
Something like this should never be in code, only in issues.
janpio
reviewed
Oct 1, 2018
| @@ -24,6 +24,11 @@ description: Open an in-app browser window. | |||
| |AppVeyor|Travis CI| | |||
| |:-:|:-:| | |||
| |[](https://ci.appveyor.com/project/ApacheSoftwareFoundation/cordova-plugin-inappbrowser)|[](https://travis-ci.org/apache/cordova-plugin-inappbrowser)| | |||
| |npm install|npm install| | |||
|
I undid the test disabling and removed the TBD comments. Only issue left here are the changes to README. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Browser, Android, iOS
What does this PR do?
.travis.ymlskip Safari browser & intermediate Android/iOS versions for now to workaround Travis CI failure.appveyor.ymladd eslint to test (consistent with test script in package.json)README.mdadd some AppVeyor CI & Travis CI info.travis.ymladd blank linesWhat testing has been done on this change?
Checklist
Reported an issue in the JIRA databaseCommit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.Added automated test coverage as appropriate for this change.